From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933713AbcBBRTf (ORCPT ); Tue, 2 Feb 2016 12:19:35 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:39228 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933696AbcBBRTe (ORCPT ); Tue, 2 Feb 2016 12:19:34 -0500 Subject: Re: [Xen-devel] [PATCH v2 02/11] xen/hvmlite: Bootstrap HVMlite guest To: David Vrabel , konrad.wilk@oracle.com References: <1454341137-14110-1-git-send-email-boris.ostrovsky@oracle.com> <1454341137-14110-3-git-send-email-boris.ostrovsky@oracle.com> <56B0DBD6.3060205@citrix.com> Cc: xen-devel@lists.xenproject.org, mcgrof@suse.com, linux-kernel@vger.kernel.org, roger.pau@citrix.com From: Boris Ostrovsky Message-ID: <56B0E521.8000701@oracle.com> Date: Tue, 2 Feb 2016 12:19:29 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <56B0DBD6.3060205@citrix.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/02/2016 11:39 AM, David Vrabel wrote: > On 01/02/16 15:38, Boris Ostrovsky wrote: >> --- a/include/xen/xen.h >> +++ b/include/xen/xen.h >> @@ -29,6 +29,12 @@ extern enum xen_domain_type xen_domain_type; >> #define xen_initial_domain() (0) >> #endif /* CONFIG_XEN_DOM0 */ >> >> +#ifdef CONFIG_XEN_PVHVM >> +extern int xen_hvmlite; >> +#else >> +#define xen_hvmlite (0) >> +#endif > I think we want a feature set and not a single boolean here. There's > going to HVMlite variants (e.g., those with an emulated APIC to support > PCI passthrough and those without). > > So we test e.g., xen_hvm_feature(XEN_HVM_FEATURE_APIC), which would be > clear for a HVMlite guest without an (emulated) APIC. I was thinking of eventually 's/xen_hvmlite/xen_pvh_domain/g' but this is better. Then we need to export features via XENVER_get_features. Alternatively, we can provide them in the hypervisor CPUID leaf. -boris