From: Dave Hansen <dave@sr71.net>
To: Vlastimil Babka <vbabka@suse.cz>, linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, x86@kernel.org,
torvalds@linux-foundation.org, dave.hansen@linux.intel.com
Subject: Re: [PATCH 22/31] x86, pkeys: dump pkey from VMA in /proc/pid/smaps
Date: Tue, 2 Feb 2016 11:04:23 -0800 [thread overview]
Message-ID: <56B0FDB7.4070500@sr71.net> (raw)
In-Reply-To: <56B0D54C.3010901@suse.cz>
On 02/02/2016 08:11 AM, Vlastimil Babka wrote:
>> +void __weak arch_show_smap(struct seq_file *m, struct vm_area_struct
>> *vma)
>> +{
>> +}
>
> Is it valid that this serves also as a declaration? Or should it be also
> in some header?
I guess having it in a header would make it less likely that someone
screws up a definition farther down the line. But, it also seemed a wee
bit of overkill for a single user.
I'm happy to send a follow-on patch to add it to a header somewhere.
next prev parent reply other threads:[~2016-02-02 19:04 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 18:16 [PATCH 00/31] x86: Memory Protection Keys (v9) Dave Hansen
2016-01-29 18:16 ` [PATCH 01/31] mm, gup: introduce concept of "foreign" get_user_pages() Dave Hansen
2016-02-09 12:46 ` Ingo Molnar
2016-02-09 13:06 ` Ingo Molnar
2016-02-09 15:15 ` Dave Hansen
2016-01-29 18:16 ` [PATCH 02/31] x86, fpu: add placeholder for Processor Trace XSAVE state Dave Hansen
2016-01-29 18:16 ` [PATCH 03/31] x86, pkeys: Add Kconfig option Dave Hansen
2016-01-29 18:16 ` [PATCH 04/31] x86, pkeys: cpuid bit definition Dave Hansen
2016-01-29 18:16 ` [PATCH 05/31] x86, pkeys: define new CR4 bit Dave Hansen
2016-01-29 18:16 ` [PATCH 06/31] x86, pkeys: add PKRU xsave fields and data structure(s) Dave Hansen
2016-01-29 18:16 ` [PATCH 07/31] x86, pkeys: PTE bits for storing protection key Dave Hansen
2016-01-29 18:16 ` [PATCH 08/31] x86, pkeys: new page fault error code bit: PF_PK Dave Hansen
2016-01-29 18:16 ` [PATCH 09/31] x86, pkeys: store protection in high VMA flags Dave Hansen
2016-01-29 18:16 ` [PATCH 10/31] x86, pkeys: arch-specific protection bits Dave Hansen
2016-01-29 18:16 ` [PATCH 11/31] x86, pkeys: pass VMA down in to fault signal generation code Dave Hansen
2016-01-29 18:16 ` [PATCH 12/31] signals, pkeys: notify userspace about protection key faults Dave Hansen
2016-01-29 18:17 ` [PATCH 13/31] x86, pkeys: fill in pkey field in siginfo Dave Hansen
2016-01-29 18:17 ` [PATCH 14/31] x86, pkeys: add functions to fetch PKRU Dave Hansen
2016-01-29 18:17 ` [PATCH 15/31] mm: factor out VMA fault permission checking Dave Hansen
2016-01-29 18:17 ` [PATCH 16/31] x86, mm: simplify get_user_pages() PTE bit handling Dave Hansen
2016-01-29 18:17 ` [PATCH 17/31] x86, pkeys: check VMAs and PTEs for protection keys Dave Hansen
2016-01-29 18:17 ` [PATCH 18/31] mm: do not enforce PKEY permissions on "foreign" mm access Dave Hansen
2016-01-29 18:17 ` [PATCH 19/31] x86, pkeys: optimize fault handling in access_error() Dave Hansen
2016-01-29 18:17 ` [PATCH 20/31] x86, pkeys: differentiate instruction fetches Dave Hansen
2016-01-29 18:17 ` [PATCH 21/31] x86, pkeys: dump PKRU with other kernel registers Dave Hansen
2016-01-29 18:17 ` [PATCH 22/31] x86, pkeys: dump pkey from VMA in /proc/pid/smaps Dave Hansen
2016-02-02 16:11 ` Vlastimil Babka
2016-02-02 19:04 ` Dave Hansen [this message]
2016-01-29 18:17 ` [PATCH 23/31] x86, pkeys: add Kconfig prompt to existing config option Dave Hansen
2016-01-29 18:17 ` [PATCH 24/31] x86, pkeys: actually enable Memory Protection Keys in CPU Dave Hansen
2016-01-29 18:17 ` [PATCH 25/31] mm, multi-arch: pass a protection key in to calc_vm_flag_bits() Dave Hansen
2016-01-29 18:17 ` [PATCH 26/31] x86, pkeys: add arch_validate_pkey() Dave Hansen
2016-01-29 18:17 ` [PATCH 27/31] x86: separate out LDT init from context init Dave Hansen
2016-01-29 18:17 ` [PATCH 28/31] x86, fpu: allow setting of XSAVE state Dave Hansen
2016-01-29 18:17 ` [PATCH 29/31] x86, pkeys: allow kernel to modify user pkey rights register Dave Hansen
2016-01-29 18:17 ` [PATCH 30/31] x86, pkeys: create an x86 arch_calc_vm_prot_bits() for VMA flags Dave Hansen
2016-01-29 18:17 ` [PATCH 31/31] x86, pkeys: execute-only support Dave Hansen
-- strict thread matches above, loose matches on Subject: below --
2016-01-07 0:01 [PATCH 00/31] x86: Memory Protection Keys (v8) Dave Hansen
2016-01-07 0:01 ` [PATCH 22/31] x86, pkeys: dump pkey from VMA in /proc/pid/smaps Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B0FDB7.4070500@sr71.net \
--to=dave@sr71.net \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).