From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S965544AbcBBTEa (ORCPT <rfc822;w@1wt.eu>);
	Tue, 2 Feb 2016 14:04:30 -0500
Received: from www.sr71.net ([198.145.64.142]:52747 "EHLO blackbird.sr71.net"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S964886AbcBBTEZ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 2 Feb 2016 14:04:25 -0500
Subject: Re: [PATCH 22/31] x86, pkeys: dump pkey from VMA in /proc/pid/smaps
To: Vlastimil Babka <vbabka@suse.cz>, linux-kernel@vger.kernel.org
References: <20160129181642.98E7D468@viggo.jf.intel.com>
 <20160129181713.3F22714C@viggo.jf.intel.com> <56B0D54C.3010901@suse.cz>
Cc: linux-mm@kvack.org, x86@kernel.org, torvalds@linux-foundation.org,
        dave.hansen@linux.intel.com
From: Dave Hansen <dave@sr71.net>
Message-ID: <56B0FDB7.4070500@sr71.net>
Date: Tue, 2 Feb 2016 11:04:23 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <56B0D54C.3010901@suse.cz>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 02/02/2016 08:11 AM, Vlastimil Babka wrote:
>> +void __weak arch_show_smap(struct seq_file *m, struct vm_area_struct
>> *vma)
>> +{
>> +}
> 
> Is it valid that this serves also as a declaration? Or should it be also
> in some header?

I guess having it in a header would make it less likely that someone
screws up a definition farther down the line.  But, it also seemed a wee
bit of overkill for a single user.

I'm happy to send a follow-on patch to add it to a header somewhere.