From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755289AbcBBX7u (ORCPT ); Tue, 2 Feb 2016 18:59:50 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:34012 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752099AbcBBX7t (ORCPT ); Tue, 2 Feb 2016 18:59:49 -0500 X-AuditID: cbfec7f5-f79b16d000005389-6a-56b142f29591 Subject: Re: [PATCH 2/4] rtc: max77686: use rtc regmap to access RTC registers To: Laxman Dewangan , lee.jones@linaro.org, alexandre.belloni@free-electrons.com, javier@osg.samsung.com References: <1454419012-18050-1-git-send-email-ldewangan@nvidia.com> <1454419012-18050-3-git-send-email-ldewangan@nvidia.com> Cc: cw00.choi@samsung.com, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com From: Krzysztof Kozlowski Message-id: <56B142F2.30206@samsung.com> Date: Wed, 03 Feb 2016 08:59:46 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <1454419012-18050-3-git-send-email-ldewangan@nvidia.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrBLMWRmVeSWpSXmKPExsVy+t/xK7qfnDaGGXxcL2fRcW0xk8X1L89Z Ld68XcNk8fqFocXSfatZLO5/PcpocXnXHDaL/Z0djA4cHk82XWT02DPxJJvHnWt72Dx6m9+x eWzpv8vu0bdlFaPH501yAexRXDYpqTmZZalF+nYJXBnbtm5iKzjNWtF59BpjA+M5li5GTg4J AROJjw/fMkPYYhIX7q1n62Lk4hASWMoocenJElYI5ymjxOVZaxhBqoQF/CTWdb5hBEmICDQw Sny++RqonQOoql7izuMykBpmgVCJCy+vg01lEzCW2Lx8CRuIzSugIbF201+wOIuAqsTPG8fY QWxRgQiJw51d7BA1ghI/Jt8Du45TwFXiU9dDFpDxzAJ6EvcvakGMl5fYvOYt8wRGgVlIOmYh VM1CUrWAkXkVo2hqaXJBcVJ6rpFecWJucWleul5yfu4mRkj4f93BuPSY1SFGAQ5GJR7eiF8b woRYE8uKK3MPMUpwMCuJ8BrLbQwT4k1JrKxKLcqPLyrNSS0+xCjNwaIkzjtz1/sQIYH0xJLU 7NTUgtQimCwTB6dUAyOvp8VUk9MPROWPTcs997z9nk32+VyWdd5TGlc9lDWdn7PlbsTDi/cK G3y8561eb/Jg0pXpjNYdVee53htcn+fF49cn8kdA5mW9o31jaM/W+Xpis5OOiCuIzJ28VcL/ iAbj8wpbdkZLmS6bG/Nkfm24/ur0N2E21c3soZ2/bx0ovq4ctZGv94kSS3FGoqEWc1FxIgAY /AgvewIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02.02.2016 22:16, Laxman Dewangan wrote: > rtc_regmap should be used to access all RTC regsiters instead > of parent regmap regardless of what chip or property have it. > > This makes the register access uniform and extendible for other > chips. > > Signed-off-by: Laxman Dewangan > CC: Krzysztof Kozlowski > CC: Javier Martinez Canillas > --- > drivers/rtc/rtc-max77686.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) Reviewed-by: Krzysztof Kozlowski Tested on Trats2/max77686: Tested-by: Krzysztof Kozlowski Best regards, Krzysztof