From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754763AbcBCAqh (ORCPT ); Tue, 2 Feb 2016 19:46:37 -0500 Received: from mail-yw0-f194.google.com ([209.85.161.194]:36326 "EHLO mail-yw0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752733AbcBCAqg (ORCPT ); Tue, 2 Feb 2016 19:46:36 -0500 Subject: Re: [PATCH 0/7] Use devm_request_region To: Alexandre Courbot References: Cc: Linus Walleij , "linux-gpio@vger.kernel.org" , Linux Kernel Mailing List From: William Breathitt Gray X-Enigmail-Draft-Status: N1110 Message-ID: <56B14DEA.2060104@gmail.com> Date: Tue, 2 Feb 2016 19:46:34 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/02/2016 07:26 PM, Alexandre Courbot wrote: > On Tue, Feb 2, 2016 at 8:54 AM, William Breathitt Gray > wrote: >> By the time request_region is called in several GPIO drivers, a >> corresponding device structure has already been allocated. The >> devm_request_region function should be used to help simplify the cleanup >> code and reduce the possible points of failure. >> >> William Breathitt Gray (7): >> gpio: 104-dio-48e: Use devm_request_region >> gpio: 104-idi-48: Use devm_request_region >> gpio: 104-idio-16: Use devm_request_region >> gpio: amd8111: Use devm_request_region >> gpio: ich: Use devm_request_region >> gpio: sch311x: Use devm_request_region >> gpio: ws16c48: Use devm_request_region >> >> drivers/gpio/gpio-104-dio-48e.c | 22 +++++++----------- >> drivers/gpio/gpio-104-idi-48.c | 22 +++++++----------- >> drivers/gpio/gpio-104-idio-16.c | 22 +++++++----------- >> drivers/gpio/gpio-amd8111.c | 7 +++--- >> drivers/gpio/gpio-ich.c | 51 ++++++++--------------------------------- >> drivers/gpio/gpio-sch311x.c | 7 +++--- >> drivers/gpio/gpio-ws16c48.c | 22 +++++++----------- >> 7 files changed, 47 insertions(+), 106 deletions(-) > > Did a quick review and this looks all good, modulo the compile warning > on patch 6. > > Reviewed-by: Alexandre Courbot The compile warning for patch 6 appears to be benign and preexisting: an unused variable. Since the warning is unrelated to this patchset, I'll submit a separate patch to remove the unused variable so that this warning will no longer show up on later compiles. William Breathitt Gray