From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Laxman Dewangan <ldewangan@nvidia.com>,
lee.jones@linaro.org, alexandre.belloni@free-electrons.com,
k.kozlowski@samsung.com
Cc: cw00.choi@samsung.com, linux-kernel@vger.kernel.org,
rtc-linux@googlegroups.com
Subject: Re: [PATCH 1/4] rtc: max77686: fix checkpatch error
Date: Wed, 3 Feb 2016 00:04:23 -0300 [thread overview]
Message-ID: <56B16E37.8070504@osg.samsung.com> (raw)
In-Reply-To: <1454419012-18050-2-git-send-email-ldewangan@nvidia.com>
Hello Laxman,
On 02/02/2016 10:16 AM, Laxman Dewangan wrote:
> Fix following check patch error in rtc-max77686 driver:
> - Alignment should match open parenthesis.
> - braces {} should be used on all arms of this statement.
> - Prefer using the BIT macro
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> ---
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
next prev parent reply other threads:[~2016-02-03 3:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 13:16 [PATCH 0/4] rtc: max77686: make max77686 rtc driver as IP driver Laxman Dewangan
2016-02-02 13:16 ` [PATCH 1/4] rtc: max77686: fix checkpatch error Laxman Dewangan
2016-02-02 23:57 ` Krzysztof Kozlowski
2016-02-03 3:04 ` Javier Martinez Canillas [this message]
2016-02-02 13:16 ` [PATCH 2/4] rtc: max77686: use rtc regmap to access RTC registers Laxman Dewangan
2016-02-02 23:59 ` Krzysztof Kozlowski
2016-02-03 3:08 ` Javier Martinez Canillas
2016-02-02 13:16 ` [PATCH 3/4] rtc: max77686: avoid reference of parent device info multiple palces Laxman Dewangan
2016-02-03 0:05 ` Krzysztof Kozlowski
2016-02-03 3:16 ` Javier Martinez Canillas
2016-02-02 13:16 ` [PATCH 4/4] rtc: max77686: move initialisation of rtc regmap, irq chip locally Laxman Dewangan
2016-02-03 1:17 ` Krzysztof Kozlowski
2016-02-03 3:48 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B16E37.8070504@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=cw00.choi@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=ldewangan@nvidia.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox