From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932840AbcBCDEm (ORCPT ); Tue, 2 Feb 2016 22:04:42 -0500 Received: from lists.s-osg.org ([54.187.51.154]:52532 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932232AbcBCDEd (ORCPT ); Tue, 2 Feb 2016 22:04:33 -0500 Subject: Re: [PATCH 1/4] rtc: max77686: fix checkpatch error To: Laxman Dewangan , lee.jones@linaro.org, alexandre.belloni@free-electrons.com, k.kozlowski@samsung.com References: <1454419012-18050-1-git-send-email-ldewangan@nvidia.com> <1454419012-18050-2-git-send-email-ldewangan@nvidia.com> Cc: cw00.choi@samsung.com, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com From: Javier Martinez Canillas Message-ID: <56B16E37.8070504@osg.samsung.com> Date: Wed, 3 Feb 2016 00:04:23 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1454419012-18050-2-git-send-email-ldewangan@nvidia.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Laxman, On 02/02/2016 10:16 AM, Laxman Dewangan wrote: > Fix following check patch error in rtc-max77686 driver: > - Alignment should match open parenthesis. > - braces {} should be used on all arms of this statement. > - Prefer using the BIT macro > > Signed-off-by: Laxman Dewangan > --- Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America