From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933856AbcBCHs7 (ORCPT ); Wed, 3 Feb 2016 02:48:59 -0500 Received: from mail-bl2on0078.outbound.protection.outlook.com ([65.55.169.78]:22400 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933379AbcBCHsy (ORCPT ); Wed, 3 Feb 2016 02:48:54 -0500 Authentication-Results: spf=pass (sender IP is 137.71.25.57) smtp.mailfrom=analog.com; arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=bestguesspass action=none header.from=analog.com; Reply-To: Subject: Re: [PATCH v3 2/3] input: touchscreen: ad7879: fix default x/y axis assignment References: <1454455218-13004-1-git-send-email-stefan@agner.ch> <1454455218-13004-2-git-send-email-stefan@agner.ch> To: Stefan Agner , , CC: , , , , , , , , From: Michael Hennerich Organization: Analog Devices Inc. Message-ID: <56B1AF36.9080204@analog.com> Date: Wed, 3 Feb 2016 08:41:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1454455218-13004-2-git-send-email-stefan@agner.ch> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11OLC005;1:By/Pzt1KTz73ys+o14E0wrOv2x9zERjhfcslsH14h4J7YLyhSIwM7uxD5ACV2RGIfjskYFUry+rkMcRlMn3ybHUfUFLiTDuWVhoPvNLk3pMM5872vmJXbDB+76lDoHhNimnI5dwNp4sDJ33S2S3E9BqyPwngSHjHPrfuzrVR9zbb8GEMBuk/Y/ubi+gMjn/ZhhqKiCJR4RmSWo1O4AYBgxO4WjMYO8PSNEvTFE2Hh2jt2mKxJJ8du7ki7NPcpK/HKia/ZSKh98H1pwpCrgw6zOWXee4qjRRA1vJpyYyvVOuYJaNBms2l1/bKnmCcWOeJlvnsvExBTL25gVcVL0xVPI+qWUCDqeZP3u8YyXhPQYOgEvNj9633ijBKwdelMVZ1jyY/LjvQeop5G8TbueWQ56rXDA6WGGHugkmQD+b1CnHfncowRpTckMUXJJ7L6ZF907o0mWHVAOo45wiAm872ktBnvPWb5n8vCZfTdvCfSR8Bs78/SWw+mhmQgYPfJlcT X-Forefront-Antispam-Report: CIP:137.71.25.57;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(3190300001)(24454002)(189002)(377454003)(479174004)(199003)(19580405001)(50466002)(33656002)(36756003)(65806001)(43066003)(19580395003)(586003)(47776003)(87266999)(86362001)(76176999)(54356999)(50986999)(230700001)(53806999)(80316001)(65816999)(4326007)(1096002)(6806005)(2950100001)(65956001)(2906002)(87936001)(11100500001)(5001770100001)(4001350100001)(106466001)(77096005)(5001970100001)(23746002)(189998001)(1220700001)(3450700001)(5008740100001)(83506001);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR03MB158;H:nwd2mta2.analog.com;FPR:;SPF:Pass;MLV:sfv;MX:1;A:1;LANG:en; X-MS-Office365-Filtering-Correlation-Id: 82a0c504-9c15-4860-8ba9-08d32c6e73c1 X-Microsoft-Exchange-Diagnostics: 1;BY2PR03MB158;2:FmNWcLD2eOeoxqfPbnbMDs+sWLuRZWU+9MwynxrAh3oj+ZF35j/QXBm44GW1Ylr0yduLbnh/2KuWOVzSzJr1xPC0smsflYG6RufIQbM1aYh4tLKloQC/HzryjTLHFxwvkLp9gQc3N/iPMKjfSsL+dZSdhX0o/8+rq+d4DO3pqr7M72mnayUX5ho6QO9CgMPz;3:bPJ9G4n8kuo0svoQvgv8YCj+xYy0H6YfNdhamlxf9JJsjlpTgLU+5RAq3WgSQzd02x7kmcIyjkrR40sN56O3er9iEvUsk26MEzeSSVinbG01ceP/Gey0wO27yRX0afQgK+gfFK856PLNOZ+pN8UQ7fX67snzDzGEAgiK5GUyW1TDZQnOkgwKhhpR2tzWKq3kMWxkHAwphPvj+qz+LlyH1qwVuq37hqa8R5u/cEo6EPm+uhnwhJZarJf6fIYA1DZwQ3cfC8o+CQjVykjCjFhMYg==;25:MteMWUXz+fYPOas37X0sOLL1IV6nwpEuDTqkMu2tlpT7ijI3H+76/ssPnUJIk9L5sEybzf5QM48KlohRSk43lwVvdh3O6P6JBLR482QrQTqWkwwpa1j7NvrYRtZfIvRXUDH1vjQwLNHLHbp382jBQ1Z8gXwh+4P1jgWdc4RKarZbMTLStQSvc36LplR0qLLDd3TxsB3zsZE38912Bh/RcxZhQS9gQbYghPOYvrTYfbh8G4XXT4PjF2GtKhs+GJEo X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:BY2PR03MB158; X-Microsoft-Exchange-Diagnostics: 1;BY2PR03MB158;20:CT7zQUxRUMksdcIYZMn9TxzPxQs+F/ndWfRc20ctFiT2are707usI4IFvStXalgDf0sJI656Xju8Zt+I54Y35ABxS2BBfebXGkRHutGL2gDxmnelOcBeNTS987zV4ho36NXZr1pUQI2y8WLUBPENlFOCBF9V7Rd2GlmMk56qr6Uo/x+Pbn1EriwcOHWvvbWVuQDHnRAhWdqcnSrAeAY4es1Usq6Ho2/uG3Q/3CGDCmV0vYdjgI/gJzfPvGkxsXjbRrlyMSmkR5784T66XKfteo/4SuKy0uiYTOy2LK169SoS233sql3x0E8dgTP4Dut+9Bj/AH54Bd0kAnAm7TlIOqSA9ItE/Mgcgqkohj3hbQNOKbxYLvNfCOp+8x8V0ufHzLIse6vx2+y8Tf+CORjtwpC5Pwbz4M41BFPdaL/A7HJvbTKzzqrqEefv7OSzjES+TunbL4IpcURUayB/9SrE2QvoIeB3ck9808Kp/yzI3WhsvSEuHaIgRujJFC3kvCsr X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(232431446821674); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13024025)(13023025)(5005006)(13015025)(13017025)(13018025)(8121501046)(3002001)(10201501046);SRVR:BY2PR03MB158;BCL:0;PCL:0;RULEID:;SRVR:BY2PR03MB158; X-Microsoft-Exchange-Diagnostics: 1;BY2PR03MB158;4:NeMnsz2Nu5DOm7a8pgXZ85gFeOcXknTkxnJ2qun32MU+6Hc+5MjhiLSe4/oDkbWXnOHNbRm5tdQirZqRhSNdmU2gfSX5C1cW7yQESdtJ7cZpA+obU4+KGq1DSJon7vOcJZCmPaJZqF6tGKiceafVTZ+I522P3b0l4+z13WXwPXjXAyknySzSSi367wu09WSbCKwWKEnwxZELOJg/Zl+eKZqT7NuaqwLIb9QKLysHsuAU+M+uxtZ8b4fUMYwUKePQ8iZAOXgcGmVRw2Z6N1kclLdJl71bUcq4vRn7Yy5Ttwx+lBEHp4QjF1uDd8zndGN8O12DDd7B5Mh7Vz9D8qadAXPzGVbEBWb1j9wAgkmXWsF48XVcvfScj8hALv8DUz/TNK/1Sy1I9u4RscIb3mDuXCeaQvRk7sQsqiuLXQWULSRNn/++zpnNsCxFia+rBqw91SnQixHboOow1AAkrqXKL/Fz2dMvfMBARTjUOhn7yiZ7NLeCuhn8Ul3EN2mfYl6j X-Forefront-PRVS: 08417837C5 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BY2PR03MB158;23:DC9b7DXJdXH4/dYiVKqrcvdoUDSEQGoT7f8LVZ?= =?Windows-1252?Q?f26OBzvad8O9db3AH5c4QORUAj8igPwWEColLPw+2GBnQpjhm3kCVxjM?= =?Windows-1252?Q?YY1XnzB9p4EOKHgbyTC6aStmhg8irfvd3R34L+H1bIwswbW0BfiN34A1?= =?Windows-1252?Q?PGJJ7yJkJYkVdIC2I/HzATpEI+Cr39yWl7QBVzCtlgShS/cL9sOtM3iV?= =?Windows-1252?Q?D7S21OKjlFzt072ZAHoYUjHcm8aswgYq1/bG6DR2Q8mdDcLVgJZrNayO?= =?Windows-1252?Q?AXZCtOXXcCkJoZ0LxebklpsAQjsdKzlZ/NoRhY7qwE5PzLDBPYTg683u?= =?Windows-1252?Q?7pP/NckVEOn/Q8nAQ1yaW0Nv2QaJLGgQfhQcpkZ0eFnuyYKrGiRzNZ7H?= =?Windows-1252?Q?ibgNRo8fbjnbuW4lpAi/4Pz1PhJWn5jnqnylgt0VMyiLJz8spVrT0Val?= =?Windows-1252?Q?ML4vUs4TBT7qiptDKkwqZYbT277GLljkUBfjHS6sSRJqJrU5uldoo0Xx?= =?Windows-1252?Q?jqjdU/8gaRxe5uCzvxInRAGkDU8Fxi9Il8Gf5EnM3ll1kn9/hwCD4IoX?= =?Windows-1252?Q?gYrWReR21f9GxrnfvCzHiqmhUaWPdcpYW5sKCWNl6zk/q78n/26bptm3?= =?Windows-1252?Q?MVFmjGIZtCE1+e3uEvaBqhO2l0BekJw/uSGV2s/JPBUbUCZLL7zJ1jzL?= =?Windows-1252?Q?FlLTx+aqGMSJMn2aW0jb9vAdI+dudeIAo5mN7VjW5XEhZJrQ6xlGZC8O?= =?Windows-1252?Q?Zv4+51eDhJHZRABDeWSA2IxkJ45CdXD+qIluNfLjNXpnYowOfbd6SM4P?= =?Windows-1252?Q?tDevjZEXqAImnnnSMSxBmpIod31WkgbeDsbIYwj9Gk6jPiZmRySb5xuw?= =?Windows-1252?Q?+HQ/nokkQkzvBxBj+jOHWp5bTn2ZqZnMjj/KpPS0Z7MkbYI2vAxCPwaP?= =?Windows-1252?Q?E9Zd1e37Br0Pb08WqOwtwZyfw6psANhoPTYqjXhCI6Fn+s7GJkMO7YoM?= =?Windows-1252?Q?fHgfHCRCwaKBkqhEaXrQMzIoZWvlBJn/w6sK1ZinQ/k47oa/GXbZONCk?= =?Windows-1252?Q?z6GAcv5rI4bsKt+RR8TtQVZwDQrjxixt7f49MF3TutTYYuVQCYDc403i?= =?Windows-1252?Q?EUNGWiCWiif0uqW289mlxmlslmoH1ueoswGtevqpTQsVZ1mMOrgnVtYm?= =?Windows-1252?Q?cLZ7rbzZO1Oe0SrMziBtWWiIB5KY6oTJn5Xq1ZSg/cqQkoggmbD6Ee2Q?= =?Windows-1252?Q?A1qiYDiRyxBj2eJ0NJ3niMaylj+EQu9le1FUdxxrvbbCOspxYo1FPWYG?= =?Windows-1252?Q?k/?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR03MB158;5:xPlTTp5D3r3l307NbkJ0/q4VSHF2hGAaRLPnkvUxLljWpI2AZx/ZjW8BocvkA/mSrQlIXmQlrml/1Y6m/fL31Y+l1Sa2GUogaQrAjdKa+Es3oaQRnjwCJVfV2bvJ6WFeVgSP2kbNp0xN4to0w/Sv5A==;24:Xl0jPjgBjHYTNuOw3mgGNvBXuHiNzhmu0Yb7Q1yKkGpc00skark7y0CNOT0hBtYuRotVw0DSYSCiXnOWwlr1GmyNqW23WIeiU3uB4wT80g0= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: analog.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2016 07:48:48.6496 (UTC) X-MS-Exchange-CrossTenant-Id: eaa689b4-8f87-40e0-9c6f-7228de4d754a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=eaa689b4-8f87-40e0-9c6f-7228de4d754a;Ip=[137.71.25.57];Helo=[nwd2mta2.analog.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR03MB158 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/03/2016 12:20 AM, Stefan Agner wrote: > The X/Y position measurements read from the controller are interpreted > wrong. The first measurement X+ contains the Y position, and the second > measurement Y+ the X position (see also Table 11 Register Table in the > data sheet). > > The problem is already known and a swap option has been introduced: > commit 6680884a4420 ("Input: ad7879 - add option to correct xy axis") > > However, the meaning of the new boolean is inverted since the underlying > values are already swapped. Let ts->swap_xy set to true actually be the > swapped configuration of the two axis. > > Signed-off-by: Stefan Agner Acked-by: Michael Hennerich > --- > Changes since v2: > - (none) > Changes since v1: > - Keep axis swapped by default when using platform data > > drivers/input/touchscreen/ad7879.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/input/touchscreen/ad7879.c b/drivers/input/touchscreen/ad7879.c > index 93b8ea2..abd0220 100644 > --- a/drivers/input/touchscreen/ad7879.c > +++ b/drivers/input/touchscreen/ad7879.c > @@ -94,8 +94,8 @@ > #define AD7879_TEMP_BIT (1<<1) > > enum { > - AD7879_SEQ_XPOS = 0, > - AD7879_SEQ_YPOS = 1, > + AD7879_SEQ_YPOS = 0, > + AD7879_SEQ_XPOS = 1, > AD7879_SEQ_Z1 = 2, > AD7879_SEQ_Z2 = 3, > AD7879_NR_SENSE = 4, > @@ -517,7 +517,9 @@ struct ad7879 *ad7879_probe(struct device *dev, u8 devid, unsigned int irq, > ts->dev = dev; > ts->input = input_dev; > ts->irq = irq; > - ts->swap_xy = pdata->swap_xy; > + > + /* Use swapped axis by default (backward compatibility) */ > + ts->swap_xy = !pdata->swap_xy; > > setup_timer(&ts->timer, ad7879_timer, (unsigned long) ts); > > -- Greetings, Michael -- Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368; Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin, Margaret Seif