From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752090AbcBCJex (ORCPT ); Wed, 3 Feb 2016 04:34:53 -0500 Received: from lucky1.263xmail.com ([211.157.147.132]:60641 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751142AbcBCJet (ORCPT ); Wed, 3 Feb 2016 04:34:49 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: zhengyang@rock-chips.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v8 1/2] drm/rockchip: hdmi: add Innosilicon HDMI support To: Jean-Francois Moine References: <1454049768-30872-1-git-send-email-ykk@rock-chips.com> <1454050059-31196-1-git-send-email-ykk@rock-chips.com> <20160129082000.b25fd19cea94c4f3ec45e17f@free.fr> Cc: Mark Yao , Heiko Stuebner , Mark Rutland , devicetree@vger.kernel.org, Pawel Moll , Ian Campbell , Ben Chan , Ken Mixte , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Rob Herring , Kumar Gala , Thierry Reding , linux-arm-kernel@lists.infradead.org, Zheng Yang From: Yakir Yang Message-ID: <56B1C9B0.3030806@rock-chips.com> Date: Wed, 3 Feb 2016 17:34:40 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20160129082000.b25fd19cea94c4f3ec45e17f@free.fr> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jean, Sorry about miss your comments :) On 01/29/2016 03:20 PM, Jean-Francois Moine wrote: > On Fri, 29 Jan 2016 14:47:39 +0800 > Yakir Yang wrote: > >> The Innosilicon HDMI is a low power HDMI 1.4 transmitter >> IP, and it have been integrated on some rockchip CPUs >> (like RK3036, RK312x). >> >> Signed-off-by: Yakir Yang >> --- >> Changes in v8: >> - Don't check whether encoder output format is RGB colorspace, cause driver >> default configure the output colorspace to RGB. (ZhengYang) >> - Correct the check condition in inno_hdmi_config_video_csc() (ZhengYang) >> - if (data->enc_out_format == data->enc_out_format) { >> + if (data->enc_in_format == data->enc_out_format) { >> >> Changes in v7: >> - Correct the module licnese statement (Paul) >> - MODULE_LICENSE("GPL"); >> + MODULE_LICENSE("GPLv2"); >> - Start indentation with tabs and fix the misspell in Kconfig (Paul) >> - Carry the lost device-binding document (Heiko) >> >> Changes in v6: >> - Rebase the Makefile/Kconfig files which add by Chris's rockchip-mipi driver (Caeser) >> >> Changes in v5: >> - Use hdmi_infoframe helper functions to packed the infoframe (Russell) >> - Remove the unused double wait_for_completion_timeout for ddc transfer (Russell) >> - Remove the unused local variable in "inno_hdmi_i2c_write()" function (Russell) >> >> Changes in v4: >> - Modify the commit title "drm/rockchip: hdmi: ..." (Mark) >> - Correct the "DKMS" to "DPMS" (Mark) >> - Fix over 80 characters problems (Mark) >> - Remove encoder .prepare/.commit helper functions, and move the vop mode >> configure function into encoder .enable helper functions. (Mark) >> >> Changes in v3: >> - Use encoder enable/disable function, and remove the encoder DPMS function >> - Keep HDMI PLL power on in standby mode >> >> Changes in v2: >> - Using DRM atomic helper functions for connector init (Mark) >> - Remove "hdmi->connector.encoder = encoder;" (Mark) >> >> drivers/gpu/drm/rockchip/Kconfig | 8 + >> drivers/gpu/drm/rockchip/Makefile | 1 + >> drivers/gpu/drm/rockchip/inno_hdmi.c | 939 +++++++++++++++++++++++++++++++++++ >> drivers/gpu/drm/rockchip/inno_hdmi.h | 362 ++++++++++++++ >> 4 files changed, 1310 insertions(+) >> create mode 100644 drivers/gpu/drm/rockchip/inno_hdmi.c >> create mode 100644 drivers/gpu/drm/rockchip/inno_hdmi.h >> >> diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig >> index 8573985..76b3362 100644 >> --- a/drivers/gpu/drm/rockchip/Kconfig >> +++ b/drivers/gpu/drm/rockchip/Kconfig >> @@ -35,3 +35,11 @@ config ROCKCHIP_DW_MIPI_DSI >> for the Synopsys DesignWare HDMI driver. If you want to >> enable MIPI DSI on RK3288 based SoC, you should selet this >> option. >> + >> +config ROCKCHIP_INNO_HDMI >> + tristate "Rockchip specific extensions for Innosilicon HDMI" >> + depends on DRM_ROCKCHIP >> + help >> + This selects support for Rockchip SoC specific extensions >> + for the Innosilicon HDMI driver. If you want to enable >> + HDMI on RK3036 based SoC, you should select this option. >> diff --git a/drivers/gpu/drm/rockchip/Makefile b/drivers/gpu/drm/rockchip/Makefile >> index f6a809a..df8fbef 100644 >> --- a/drivers/gpu/drm/rockchip/Makefile >> +++ b/drivers/gpu/drm/rockchip/Makefile >> @@ -8,5 +8,6 @@ rockchipdrm-$(CONFIG_DRM_FBDEV_EMULATION) += rockchip_drm_fbdev.o >> >> obj-$(CONFIG_ROCKCHIP_DW_HDMI) += dw_hdmi-rockchip.o >> obj-$(CONFIG_ROCKCHIP_DW_MIPI_DSI) += dw-mipi-dsi.o >> +obj-$(CONFIG_ROCKCHIP_INNO_HDMI) += inno_hdmi.o >> >> obj-$(CONFIG_DRM_ROCKCHIP) += rockchipdrm.o rockchip_vop_reg.o >> diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c >> new file mode 100644 >> index 0000000..c99d88d >> --- /dev/null >> +++ b/drivers/gpu/drm/rockchip/inno_hdmi.c >> @@ -0,0 +1,939 @@ >> +/* >> + * Copyright (C) Fuzhou Rockchip Electronics Co.Ltd >> + * Zheng Yang >> + * Yakir Yang >> + * >> + * This software is licensed under the terms of the GNU General Public >> + * License version 2, as published by the Free Software Foundation, and >> + * may be copied, distributed, and modified under those terms. >> + * >> + * This program is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + */ >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include > This is not needed. Do you mean the "drm_encoder_slave.h" file ? Yep, seems I haven't called ant encoder slave helper functions, thanks. > >> + >> +#include "rockchip_drm_drv.h" >> +#include "rockchip_drm_vop.h" >> + >> +#include "inno_hdmi.h" > [snip] >