From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Laxman Dewangan <ldewangan@nvidia.com>,
lee.jones@linaro.org, alexandre.belloni@free-electrons.com,
javier@osg.samsung.com
Cc: cw00.choi@samsung.com, linux-kernel@vger.kernel.org,
rtc-linux@googlegroups.com
Subject: Re: [PATCH V2 4/5] mfd: max77686: do not set i2c client data for rtc i2c client
Date: Wed, 03 Feb 2016 19:19:07 +0900 [thread overview]
Message-ID: <56B1D41B.4090602@samsung.com> (raw)
In-Reply-To: <1454491848-26551-5-git-send-email-ldewangan@nvidia.com>
On 03.02.2016 18:30, Laxman Dewangan wrote:
> There is different RTC I2C address for RTC block in MAX77686.
> Driver is creating dummy i2c client for this address to access
> the register of this IP block.
>
> As there is no need to get any data from this rtc i2c client,
> it is not required to set client data for this i2c client.
>
> Suggested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> CC: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> CC: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
> This is new in this series based on review comment from V1.
>
You could trim a little bit the description - "stored pointer is not
retrieved anywhere, there is no call to i2c_get_clientdata()" might be
sufficient but anyway:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2016-02-03 10:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 9:30 [PATCH V2 0/5] rtc: max77686: make max77686 rtc driver as IP driver Laxman Dewangan
2016-02-03 9:30 ` [PATCH V2 1/5] rtc: max77686: fix checkpatch error Laxman Dewangan
2016-02-03 9:30 ` [PATCH V2 2/5] rtc: max77686: use rtc regmap to access RTC registers Laxman Dewangan
2016-02-03 9:30 ` [PATCH V2 3/5] rtc: max77686: avoid reference of parent device info multiple palces Laxman Dewangan
2016-02-03 12:45 ` Javier Martinez Canillas
2016-02-03 9:30 ` [PATCH V2 4/5] mfd: max77686: do not set i2c client data for rtc i2c client Laxman Dewangan
2016-02-03 10:19 ` Krzysztof Kozlowski [this message]
2016-02-03 12:47 ` Javier Martinez Canillas
2016-02-03 9:30 ` [PATCH V2 5/5] rtc: max77686: move initialisation of rtc regmap, irq chip locally Laxman Dewangan
2016-02-03 10:45 ` Krzysztof Kozlowski
2016-02-03 11:22 ` Krzysztof Kozlowski
2016-02-03 13:13 ` Laxman Dewangan
2016-02-03 12:56 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B1D41B.4090602@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=cw00.choi@samsung.com \
--cc=javier@osg.samsung.com \
--cc=ldewangan@nvidia.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox