From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751828AbcBCKgI (ORCPT ); Wed, 3 Feb 2016 05:36:08 -0500 Received: from mail-lf0-f44.google.com ([209.85.215.44]:33301 "EHLO mail-lf0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750741AbcBCKgE (ORCPT ); Wed, 3 Feb 2016 05:36:04 -0500 Subject: Re: [PATCH 4/5] MIPS: Support R_MIPS_PC16 rel-style reloc To: Paul Burton References: <1454471085-20963-1-git-send-email-paul.burton@imgtec.com> <1454471085-20963-5-git-send-email-paul.burton@imgtec.com> <56B1D5B5.6050208@cogentembedded.com> <20160203103255.GA21157@NP-P-BURTON> Cc: linux-mips@linux-mips.org, Ralf Baechle , Andrey Konovalov , Andrey Ryabinin , linux-kernel@vger.kernel.org, Andrew Morton From: Sergei Shtylyov Message-ID: <56B1D810.4040606@cogentembedded.com> Date: Wed, 3 Feb 2016 13:36:00 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160203103255.GA21157@NP-P-BURTON> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/3/2016 1:32 PM, Paul Burton wrote: >>> MIPS32 code uses rel-style relocs, and MIPS32r6 modules may include the >>> R_MIPS_PC16 relocation. We thus need to support R_MIPS_PC16 rel-style >>> relocations in order to load MIPS32r6 kernel modules. This patch adds >>> such support, which is similar to the rela-style R_MIPS_PC16 support but >> >> R_MIPS_LO16, you mean? > > Hi Sergei, > > No, I mean it's similar to the R_MIPS_PC16 code in module-rela.c. That > is, its rela-style equivalent (rather than rel-style as here). But you're *adding* R_MIPS_PC16, no? > Thanks, > Paul MBR, Sergei