From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S965885AbcBCT3g (ORCPT <rfc822;w@1wt.eu>);
	Wed, 3 Feb 2016 14:29:36 -0500
Received: from mail-pf0-f176.google.com ([209.85.192.176]:35915 "EHLO
	mail-pf0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S965248AbcBCT3f (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 3 Feb 2016 14:29:35 -0500
Subject: Re: [PATCH] init: print warning message if /dev/console failed to
 open
To: Alexander Kuleshov <kuleshovmail@gmail.com>
References: <1454525928-17190-1-git-send-email-kuleshovmail@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        "Paul E . McKenney" <paulmck@linux.vnet.ibm.com>,
        Pranith Kumar <bobby.prani@gmail.com>,
        David Howells <dhowells@redhat.com>, Tejun Heo <tj@kernel.org>,
        Johannes Weiner <hannes@cmpxchg.org>,
        David Woodhouse <David.Woodhouse@intel.com>,
        linux-kernel@vger.kernel.org
From: Peter Hurley <peter@hurleysoftware.com>
Message-ID: <56B2551D.807@hurleysoftware.com>
Date: Wed, 3 Feb 2016 11:29:33 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <1454525928-17190-1-git-send-email-kuleshovmail@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Alexander,

On 02/03/2016 10:58 AM, Alexander Kuleshov wrote:
> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
> ---
>  init/do_mounts.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/init/do_mounts.c b/init/do_mounts.c
> index dea5de9..ca5da05 100644
> --- a/init/do_mounts.c
> +++ b/init/do_mounts.c
> @@ -505,7 +505,9 @@ void __init change_floppy(char *fmt, ...)
>  		termios.c_lflag |= ICANON;
>  		sys_ioctl(fd, TCSETSF, (long)&termios);
>  		sys_close(fd);
> -	}
> +	} else
> +		pr_err("Warning: unable to open /dev/console.\n");

I think you should include the -fd error code as well.

Is this failure new?


Regards,
Peter Hurley

> +
>  }
>  #endif
>  
>