From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965060AbcBCVSQ (ORCPT ); Wed, 3 Feb 2016 16:18:16 -0500 Received: from mout.gmx.net ([212.227.17.21]:56687 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965029AbcBCVSN (ORCPT ); Wed, 3 Feb 2016 16:18:13 -0500 Subject: Re: [RFT PATCH] powerpc: convert amigaone_defconfig to use libata PATA drivers To: Bartlomiej Zolnierkiewicz , linuxppc-dev@lists.ozlabs.org, Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman References: <1454514630-29269-1-git-send-email-b.zolnierkie@samsung.com> <1454514630-29269-12-git-send-email-b.zolnierkie@samsung.com> Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org From: Gerhard Pircher X-Enigmail-Draft-Status: N1110 Message-ID: <56B26E7F.70307@gmx.net> Date: Wed, 3 Feb 2016 22:17:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.5.0 MIME-Version: 1.0 In-Reply-To: <1454514630-29269-12-git-send-email-b.zolnierkie@samsung.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:uyFyDcaPWjF0iLThSpsqzyHw0IJYIzDLcLIHSPFx4WXLV6/J6Ru ePPn2o11YfXIDLB22Z/q+rdzwC4NGtZQqVgdKRpJiHAlcz7mAIz/+DEadw6EsPlZS8iCBO7 NMfw5CmB4uDfs/G0QPzMX8kYsVUd40yC9n8dFkaAz/8pokEoYUZRtkVSquObJmm4s6NbE+d IgLSok4TLiBAOZ5R8N89w== X-UI-Out-Filterresults: notjunk:1;V01:K0:XzOS+op0NAY=:RC8BvZlXopM5EjyCfB3PAW tMwXmg3QVPK5ngAdg2549ekWg1T/RAjPIEx+59VIKuFLJ7n/vbiIyDzrPw71KZ+K5ulqRDoH6 4T+ON5Ji0qxYj+YUZWkuxF0R9rN7/jF+MMedOzASsOAKXLhVKaMhX/+SbX9MC0jSy4RiOH5X7 8Hi/mPIUW/pkTwUwwwodozbt2HPsn5BgbkEXqxAoZX3KI3HL/Gs1JS6Q/5P0NbYI81q3Q0aIw cp3HUrznl8rofpJzRO0rLVeGVtcPP+SbodoxmsVqxJIXpQ+VLbFI8kizw+r3LZyg1xm6DfVPb BUugDqoXS/tjXefU6IYgQZXcn7y5bkP2oyem3t2Z42I4+g16LJaP06/hu8Mb5r/chAqlYcqaJ S/IJoBELV1803E7lF90H5gRIISajtkM0v3EF9KrofzJeLNdMfbUzLrf1tTkgGB4xS23s1rmID KH5bBpBWtMvsMwjqClzAoa5Hm7fnwerCGgbb6AugKP9FQ08/1XJVD9pzgXjL7QkLAoFdIeRia fH4QVVhQGi7FwmjCBFmxvxkr7OuK83zOVqMFiW6hJ54RxpsMniL7mimAuLQrsIRY8WlRDD/1Q VKn5gWtv5MK8121g7VMH3uJUaj7AKFCNWY+cN03nsz9rJkkTqWd7goqDcTxXWR73N4GSTIfu1 u5JS+y0tmIX9nBu19uwmFtXunC8S+c8OONa3AL8oAeL7zCdJVUHcDpnW4HKwREQmorqmXlsAz 2oTacEOxrdSNr2uTayxhePUFY2PkPN3soH/S9E1HD4y4TXhaMFBFwFK0YdM62Ct0Z2cHiXagc osddjWd Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 2016-02-03 um 16:50 schrieb Bartlomiej Zolnierkiewicz: > IDE subsystem has been deprecated since 2009 and the majority > (if not all) of Linux distributions have switched to use > libata for ATA support exclusively. However there are still > some users (mostly old or/and embedded non-x86 systems) that > have not converted from using IDE subsystem to libata PATA > drivers. This doesn't seem to be good thing in the long-term > for Linux as while there is less and less PATA systems left > in use: > > * testing efforts are divided between two subsystems > > * having duplicate drivers for same hardware confuses users > > This patch converts amigaone_defconfig to use libata PATA > drivers. > > Signed-off-by: Bartlomiej Zolnierkiewicz > --- > Build tested only. > If you have affected hardware please test. Thank you. > > arch/powerpc/configs/amigaone_defconfig | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/arch/powerpc/configs/amigaone_defconfig b/arch/powerpc/configs/amigaone_defconfig > index 84f1b41..55a4929 100644 > --- a/arch/powerpc/configs/amigaone_defconfig > +++ b/arch/powerpc/configs/amigaone_defconfig > @@ -46,12 +46,6 @@ CONFIG_PARPORT_PC_FIFO=y > CONFIG_BLK_DEV_FD=y > CONFIG_BLK_DEV_LOOP=y > CONFIG_BLK_DEV_RAM=y > -CONFIG_IDE=y > -CONFIG_BLK_DEV_IDECD=y > -# CONFIG_IDEPCI_PCIBUS_ORDER is not set > -CONFIG_BLK_DEV_GENERIC=y > -CONFIG_BLK_DEV_SIIMAGE=y > -CONFIG_BLK_DEV_VIA82CXXX=y > CONFIG_SCSI=y > CONFIG_BLK_DEV_SD=y > CONFIG_CHR_DEV_ST=y > @@ -62,6 +56,10 @@ CONFIG_SCSI_CONSTANTS=y > CONFIG_SCSI_SYM53C8XX_2=y > CONFIG_SCSI_SYM53C8XX_DMA_ADDRESSING_MODE=0 > # CONFIG_SCSI_SYM53C8XX_MMIO is not set > +CONFIG_ATA=y > +CONFIG_PATA_SIL680=y > +CONFIG_PATA_VIA=y > +CONFIG_ATA_GENERIC=y > CONFIG_NETDEVICES=y > CONFIG_VORTEX=y > CONFIG_8139CP=y > Thanks for cleaning up the defconfig file! libata drivers work fine on the amigaone platform (tested on all three first-gen AmigaOne machines). BTW: could it be that CONFIG_ATA_SFF=y and CONFIG_ATA_BMDMA=y are missing in the patch? br, Gerhard