From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756325AbcBDBVy (ORCPT <rfc822;w@1wt.eu>);
	Wed, 3 Feb 2016 20:21:54 -0500
Received: from szxga02-in.huawei.com ([119.145.14.65]:8328 "EHLO
	szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751642AbcBDBVw (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 3 Feb 2016 20:21:52 -0500
Subject: Re: [PATCH] locking/mutex: Avoid spinner vs waiter starvation
To: Davidlohr Bueso <dave@stgolabs.net>
References: <20160122105312.GQ6357@twins.programming.kicks-ass.net>
 <20160122105652.GE6375@twins.programming.kicks-ass.net>
 <20160122110653.GF6375@twins.programming.kicks-ass.net>
 <56A235DC.2060900@hpe.com> <56A48566.9040206@huawei.com>
 <20160129095347.GA6356@twins.programming.kicks-ass.net>
 <56AC0F74.2040808@huawei.com>
 <20160201100824.GO6357@twins.programming.kicks-ass.net>
 <20160202211906.GD16147@linux-uzut.site> <56B1A7D8.4050205@huawei.com>
 <20160203192458.GA26475@linux-uzut.site>
CC: Peter Zijlstra <peterz@infradead.org>, Waiman Long <waiman.long@hpe.com>,
        Jason Low <jason.low2@hp.com>, Ingo Molnar <mingo@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        "Paul E. McKenney" <paulmck@us.ibm.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Will Deacon <Will.Deacon@arm.com>,
        "Tim Chen" <tim.c.chen@linux.intel.com>,
        Waiman Long <Waiman.Long@hp.com>
From: Ding Tianhong <dingtianhong@huawei.com>
Message-ID: <56B2A749.8080400@huawei.com>
Date: Thu, 4 Feb 2016 09:20:09 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <20160203192458.GA26475@linux-uzut.site>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.177.22.246]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A0B0201.56B2A754.002F,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-06-18 04:22:30,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 6a83ba015cd85486c2a71ed6fc1f42e8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2016/2/4 3:24, Davidlohr Bueso wrote:
> On Wed, 03 Feb 2016, Ding Tianhong wrote:
> 
>> Agree, but this patch is going to help the waiter in the wait list to get the lock, your scene probability looks more
>> too low and I don't think it is a problem.
> 
> Sure, I was in fact implying its not the end of the world,
> although it will be interesting to see the impact on different
> (non pathological) workloads, even if it only affects a single
> waiter. Also, technically this issue can also affect rwsems if
> only using writers, but that's obviously pretty idiotic, so I
> wouldn't worry about it.
> 
> Thanks,
> Davidlohr
> 

Hi Davidlohr, Peter:

According Davidlohr's suggestion, I use several VM to test Peter's patch, and sadly I found one VM
still happen Hung Task for this problem, so I think we still need to think more about this solution.

Thanks.
Ding

> .
>