From: Juerg Haefliger <juerg.haefliger@hpe.com>
To: David Howells <dhowells@redhat.com>
Cc: linux-kernel@vger.kernel.org, keyrings@vger.kernel.org,
dwmw2@infradead.org
Subject: Re: [PATCH] scripts/sign-file.c: Add support for signing with a raw signature
Date: Thu, 4 Feb 2016 10:07:49 +0100 [thread overview]
Message-ID: <56B314E5.5000000@hpe.com> (raw)
In-Reply-To: <13368.1454531662@warthog.procyon.org.uk>
On 02/03/2016 09:34 PM, David Howells wrote:
> Juerg Haefliger <juerg.haefliger@hpe.com> wrote:
>
>> +static EVP_PKEY *read_private_key(char *private_key_name)
>
> const char * please.
>
>> +static X509 *read_x509(char *x509_name)
>
> And here.
Why? These functions do return pointers to EVP_PKEY and X509 structs.
...Juerg
> David
>
next prev parent reply other threads:[~2016-02-04 9:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-30 9:18 [PATCH] scripts/sign-file.c: Add support for signing with a raw signature Juerg Haefliger
2016-02-03 20:34 ` David Howells
2016-02-04 9:07 ` Juerg Haefliger [this message]
2016-02-04 10:42 ` David Howells
2016-02-03 20:45 ` David Howells
2016-02-04 11:09 ` [PATCH v2] " Juerg Haefliger
2016-02-09 16:44 ` David Howells
2016-02-10 10:12 ` David Howells
2016-02-10 10:25 ` David Woodhouse
2016-02-10 13:07 ` Juerg Haefliger
2016-02-10 13:24 ` Juerg Haefliger
2016-02-18 9:26 ` Juerg Haefliger
2016-02-18 17:23 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B314E5.5000000@hpe.com \
--to=juerg.haefliger@hpe.com \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).