From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S965598AbcBDJH6 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 4 Feb 2016 04:07:58 -0500
Received: from g1t6225.austin.hp.com ([15.73.96.126]:33081 "EHLO
	g1t6225.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S965211AbcBDJHx (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 4 Feb 2016 04:07:53 -0500
Subject: Re: [PATCH] scripts/sign-file.c: Add support for signing with a raw
 signature
To: David Howells <dhowells@redhat.com>
References: <1454145497-4567-1-git-send-email-juerg.haefliger@hpe.com>
 <13368.1454531662@warthog.procyon.org.uk>
Cc: linux-kernel@vger.kernel.org, keyrings@vger.kernel.org,
        dwmw2@infradead.org
From: Juerg Haefliger <juerg.haefliger@hpe.com>
Message-ID: <56B314E5.5000000@hpe.com>
Date: Thu, 4 Feb 2016 10:07:49 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <13368.1454531662@warthog.procyon.org.uk>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 02/03/2016 09:34 PM, David Howells wrote:
> Juerg Haefliger <juerg.haefliger@hpe.com> wrote:
> 
>> +static EVP_PKEY *read_private_key(char *private_key_name)
> 
> const char * please.
> 
>> +static X509 *read_x509(char *x509_name)
> 
> And here.

Why? These functions do return pointers to EVP_PKEY and X509 structs.

...Juerg


> David
>