From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932847AbcBDMMx (ORCPT ); Thu, 4 Feb 2016 07:12:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54762 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750798AbcBDMMv (ORCPT ); Thu, 4 Feb 2016 07:12:51 -0500 Subject: Re: [PATCH][V2] IB/sysfs: remove unused va_list args To: Colin King , Sean Hefty , Hal Rosenstock , Ira Weiny , Christoph Lameter , Matan Barak , Jason Gunthorpe , Or Gerlitz , linux-rdma@vger.kernel.org References: <1453747086-31000-1-git-send-email-colin.king@canonical.com> Cc: linux-kernel@vger.kernel.org, kernel-team@ubuntu.com From: Doug Ledford Openpgp: id=AE6B1BDA122B23B4265B1274B826A3330E572FDD; url=pgp.mit.edu Organization: Red Hat, Inc. Message-ID: <56B3403B.2020708@redhat.com> Date: Thu, 4 Feb 2016 07:12:43 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1453747086-31000-1-git-send-email-colin.king@canonical.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OfEPKBNa4Pdc123wNR1iwo653O5numivA" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --OfEPKBNa4Pdc123wNR1iwo653O5numivA Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 01/25/2016 01:38 PM, Colin King wrote: > From: Colin Ian King >=20 > _show_port_gid_attr performs a va_end on some unused va_list args. > Clean this up by removing the args completely. >=20 > Fixes: 470be516a226e8 ("IB/core: Add gid attributes to sysfs") > Signed-off-by: Colin Ian King > --- > drivers/infiniband/core/sysfs.c | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/drivers/infiniband/core/sysfs.c b/drivers/infiniband/core/= sysfs.c > index 3de9351..ec46386 100644 > --- a/drivers/infiniband/core/sysfs.c > +++ b/drivers/infiniband/core/sysfs.c > @@ -336,7 +336,6 @@ static ssize_t _show_port_gid_attr(struct ib_port *= p, > union ib_gid gid; > struct ib_gid_attr gid_attr =3D {}; > ssize_t ret; > - va_list args; > =20 > ret =3D ib_query_gid(p->ibdev, p->port_num, tab_attr->index, &gid, > &gid_attr); > @@ -348,7 +347,6 @@ static ssize_t _show_port_gid_attr(struct ib_port *= p, > err: > if (gid_attr.ndev) > dev_put(gid_attr.ndev); > - va_end(args); > return ret; > } > =20 >=20 Thanks, applied. --=20 Doug Ledford GPG KeyID: 0E572FDD --OfEPKBNa4Pdc123wNR1iwo653O5numivA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCAAGBQJWs0A7AAoJELgmozMOVy/dh+MQAIHQfcMo+LQcYvGEywQeQ/2h 3X/95XhUnXY7cQkvYLPwoTFuehcmUQD0V+ITu/NW90rsUVEWTmmFmW/d0sPXGVv2 z0x7Hb61qAT0H90QCAHH8XlS25yoLhakBxR84U54EAQ/wt4MuribehlXk6cw6+MM vtn4+BI4O1YOjDQ395ZUFxFwCCuyF3YP8yBurKtuvh19TtgxMbaApAc4Qg4KJJbX UhBU+nUK7QDQrjTuZEFaYtEv7nLOkWxjoSj7Dx6vV4jw8AlBAsNa5XZBTmHSmrKh wiDuuVAckakC91OqLvUdM8RZNzY7HzqsXRyDcSZM6Xu+MoYCCmmrJ0egx2GrFm2f 9yFThGiG5C4hgTJYpqQUaEcleJiiiILaVHuSMXLRSzQop5tx2kfwNM5He0eQIuI/ zHfXIBRIqFt7lyv9KFHKOE/K9p+dE/0nkFBE2n+aVW+Fruf6oYHqFXvLpHBEw99N sui3BIabfKu8QSS3BcrDj5GQpXoG6BWLr0UCTa2gch50tgdRePVBSa5DWuf4lCCo 1Oa296eZJbMpxe0aHiEIhKZgei6DXMq6ZWfXJlf22YctLuAXEiU8jESp9ImkeJ20 DrvilnPJZLnEhA/AxkVL+QU5jh19M1P/LWSJ/BDg79WQz8omU3Ktq4yccxn9EREb 1xdOtkObfwv+gaG846TU =peGO -----END PGP SIGNATURE----- --OfEPKBNa4Pdc123wNR1iwo653O5numivA--