From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965146AbcBDMPK (ORCPT ); Thu, 4 Feb 2016 07:15:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53418 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964837AbcBDMPI (ORCPT ); Thu, 4 Feb 2016 07:15:08 -0500 Subject: Re: [PATCH] staging: amso1100: fix format string for 64-bit phys_addr To: Arnd Bergmann , Sean Hefty , Hal Rosenstock References: <2307631.X1DYNXxKPZ@wuerfel> Cc: Greg Kroah-Hartman , linux-rdma@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Doug Ledford Openpgp: id=AE6B1BDA122B23B4265B1274B826A3330E572FDD; url=pgp.mit.edu Organization: Red Hat, Inc. Message-ID: <56B340C9.2060303@redhat.com> Date: Thu, 4 Feb 2016 07:15:05 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <2307631.X1DYNXxKPZ@wuerfel> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TfXDq459stieGfTPL357f35kb5KxC2AAm" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --TfXDq459stieGfTPL357f35kb5KxC2AAm Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 02/01/2016 11:34 AM, Arnd Bergmann wrote: > The amso1100 driver prints a phys_addr_t by casting it to a pointer, > which causes a warning when phys_addr_t is 64-bit and pointers > are 32-bit: >=20 > drivers/staging/rdma/amso1100/c2.c: In function 'c2_rx_error': > drivers/staging/rdma/amso1100/c2.c:430:4: warning: cast to pointer from= integer of different size [-Wint-to-pointer-cast] >=20 > This changes the format string to print the address as a 64-bit > number all the time to avoids the warnings. Ideally we would use > the %pap format string for phys_addr_t, but that doesn't work > here easily as it requires passing a pointer to the address. >=20 > Signed-off-by: Arnd Bergmann > --- > Found on ARM randconfig testing. This must have been there forever but = is > rather hard to trigger even with randconfig builds. >=20 > diff --git a/drivers/staging/rdma/amso1100/c2.c b/drivers/staging/rdma/= amso1100/c2.c > index b46ebd1ae15a..170a42a60552 100644 > --- a/drivers/staging/rdma/amso1100/c2.c > +++ b/drivers/staging/rdma/amso1100/c2.c > @@ -426,8 +426,8 @@ static void c2_rx_error(struct c2_port *c2_port, st= ruct c2_element *elem) > pr_debug(" index : %Zu\n", > elem - c2_port->rx_ring.start); > pr_debug(" len : %u\n", rx_desc->len); > - pr_debug(" rxp_hdr : %p [PA %p]\n", rxp_hdr, > - (void *) __pa((unsigned long) rxp_hdr)); > + pr_debug(" rxp_hdr : %p [PA %016llx\n", rxp_hdr, > + (u64)__pa((unsigned long) rxp_hdr)); > pr_debug(" flags : 0x%x\n", rxp_hdr->flags); > pr_debug(" status: 0x%x\n", rxp_hdr->status); > pr_debug(" len : %u\n", rxp_hdr->len); >=20 I've sent off a deletion of this file to Linus already, sorry. --=20 Doug Ledford GPG KeyID: 0E572FDD --TfXDq459stieGfTPL357f35kb5KxC2AAm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCAAGBQJWs0DJAAoJELgmozMOVy/dpCcQAKamySMMWSqDpl4Zfwg+Df+w tlBG50/qkg22qdawiIwMkAJ+ksTNQudNfmY45Na3Jcb+eJXyJJhjJ+LhzaC7qkGT u41cc16bE0LoImjdU4Hzb0x4MixDNIQ22wb1rZf78EluSSUViTMRC9sgi4ZNmmdM qTuSXJkXk2OcZ6FSyy/sX9nZSQmvg6p2HVxFcoSdwEJMsHWittEdhFvl8uSjKneO xZ0amNQQNNB1Tx2I3DNpjSnDgTILEbUtAeum64I40SWjavJTRPtpPDkTmeS78yfc ut2IUjxoj+6bE2HATUiiU8PHKSFaOhUm0tOHKhHS7XJ6G22mEOszJa4k9IU0IH4D ob+BqfE4cDeZ9FABrVWB3qYNJLKLu61SrRYdJa9yAUihJEQYetTwKKz9YhMMIVmT YsqKpxejKfTbTDIhDobStXM5LDWq/D7Md9i4bM58gCOcWA6eFJ4ypXP+ivCjneHH HfO3mdiPy7v8tZwdW7qTvRkWm/GGq2JkjYsQh/iCmeRBp1uk/WM7QQuEMWAr18Ad kbjoDalEyGLukHjZCRn3e158ZJ3NzksoOnuITOWGq11QYCl79hcrykt4r4GI/5Mq pAPdkgWahd/C9IC54SyICoqDDrzNgaI4Cq3J2UTvAXMFJpb2n4OHL8/XlOUgTO94 YK2teFCkfhSWST8dHQLw =wE+3 -----END PGP SIGNATURE----- --TfXDq459stieGfTPL357f35kb5KxC2AAm--