From: walter harms <wharms@bfs.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>,
Jaewon Kim <jaewon02.kim@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] extcon: use correct size
Date: Thu, 04 Feb 2016 13:47:41 +0100 [thread overview]
Message-ID: <56B3486D.1050201@bfs.de> (raw)
In-Reply-To: <20160204113609.GA11239@mwanda>
Am 04.02.2016 12:36, schrieb Dan Carpenter:
> The info->status[] array has 3 elements. We are using size
> MAX77843_MUIC_IRQ_NUM (16) instead of MAX77843_MUIC_STATUS_NUM (3) as
> intended.
>
> Fixes: 135d9f7d135a ('extcon: max77843: Clear IRQ bits state before request IRQ')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> This is from static analysis and *NOT TESTED*. Please review carefully.
>
> diff --git a/drivers/extcon/extcon-max77843.c b/drivers/extcon/extcon-max77843.c
> index 7bbc300..b188bd6 100644
> --- a/drivers/extcon/extcon-max77843.c
> +++ b/drivers/extcon/extcon-max77843.c
> @@ -806,7 +806,7 @@ static int max77843_muic_probe(struct platform_device *pdev)
> /* Clear IRQ bits before request IRQs */
> ret = regmap_bulk_read(max77843->regmap_muic,
> MAX77843_MUIC_REG_INT1, info->status,
> - MAX77843_MUIC_IRQ_NUM);
> + MAX77843_MUIC_STATUS_NUM);
> if (ret) {
> dev_err(&pdev->dev, "Failed to Clear IRQ bits\n");
> goto err_muic_irq;
> --
just for my curiosity: what is wrong with ARRAY_SIZE() ?
So far i understand is the functions intention to fill the array
completely.
re,
wh
next prev parent reply other threads:[~2016-02-04 12:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-04 11:36 [patch] extcon: use correct size Dan Carpenter
2016-02-04 12:47 ` walter harms [this message]
2016-02-04 19:53 ` Dan Carpenter
2016-02-05 2:09 ` 김재원
2016-02-05 1:58 ` Krzysztof Kozlowski
2016-02-05 5:14 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B3486D.1050201@bfs.de \
--to=wharms@bfs.de \
--cc=cw00.choi@samsung.com \
--cc=dan.carpenter@oracle.com \
--cc=jaewon02.kim@samsung.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).