From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752095AbcBEFOk (ORCPT ); Fri, 5 Feb 2016 00:14:40 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:50031 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751636AbcBEFOi convert rfc822-to-8bit (ORCPT ); Fri, 5 Feb 2016 00:14:38 -0500 X-AuditID: cbfee691-f79766d0000012b6-43-56b42fbc2164 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8BIT Message-id: <56B42FBC.2090806@samsung.com> Date: Fri, 05 Feb 2016 14:14:36 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Dan Carpenter , MyungJoo Ham , Jaewon Kim Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] extcon: use correct size References: <20160204113609.GA11239@mwanda> In-reply-to: <20160204113609.GA11239@mwanda> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrKIsWRmVeSWpSXmKPExsWyRsSkRHeP/pYwg2N7TCxe/5vOYrGj4Qir xdZb0haXd81hs7jduILNgdXj49NbLB59W1YxenzeJBfAHMVlk5Kak1mWWqRvl8CV0X7mF1NB G1dFS0M/SwPjYo4uRk4OCQETiX3ds5kgbDGJC/fWs3UxcnEICaxglPj79g5jFyMHWNH7VzIQ 8aWMEsu2r2YDaeAVEJT4MfkeC4jNLKAuMWneImYIW0RixcHFrBC2tsSyha+ZIZofAA39cZMV ollL4t6/DewgNouAqsS913vAbDag+P4XN9hAFosKREh0n6gECYsI1Elc2rgNaqajxJcThxhB bGEBXYkVPz+CPSAEtGvW1KVgt3EK6EgcffwS7BkJgW3sEsfPL2SE2CUg8W3yIRaIx2QlNh1g hnheUuLgihssExjFZyF5bRaS12YheW0WktcWMLKsYhRNLUguKE5KLzLVK07MLS7NS9dLzs/d xAiMvdP/nk3cwXj/gPUhRgEORiUe3ozVm8OEWBPLiitzDzGaAl00kVlKNDkfGOF5JfGGxmZG FqYmpsZG5pZmSuK8OtI/g4UE0hNLUrNTUwtSi+KLSnNSiw8xMnFwSjUwuifw3dm8R/jiucW7 9buvMoZkPAmZUeUrmOBzUDPFqmANf+o8rd2GqS7LBL48/LP/+Zvfmayf/8nMsvhZkn103ZRU tcorM6+VLL885dJqoSYxXr5PhVK7nHz9FFXLgi0Xam7k0krcEPVp97MZ0bOsC5um6Lz7K9Ek rjHZ22G/PXuC8JxSxcJZSizFGYmGWsxFxYkAhVmqYrgCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrBIsWRmVeSWpSXmKPExsVy+t9jAd09+lvCDLq+6Fq8/jedxWJHwxFW i623pC0u75rDZnG7cQWbA6vHx6e3WDz6tqxi9Pi8SS6AOaqB0SYjNTEltUghNS85PyUzL91W yTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMHaKWSQlliTilQKCCxuFhJ3w7ThNAQN10L mMYIXd+QILgeIwM0kLCGMePYri3MBZ84K/oOb2FuYOzn6GLk4JAQMJF4/0qmi5ETyBSTuHBv PVsXIxeHkMBSRoll21ezgSR4BQQlfky+xwJSzywgL3HkUjZImFlAXWLSvEXMEPUPGCX+/rjJ ClGvJXHv3wZ2EJtFQFXi3us9YDYbUHz/ixtsIHNEBSIkuk9UgoRFBOokLm3cxgox01Hiy4lD jCC2sICuxIqfH5lAbCEBbYlZU5eCncMpoCNx9PFLtgmMArOQXDcL4bpZSK5bwMi8ilEitSC5 oDgpPdcwL7Vcrzgxt7g0L10vOT93EyM4Vp9J7WA8uMv9EKMAB6MSD++BtZvDhFgTy4orcw8x SnAwK4nwGqpvCRPiTUmsrEotyo8vKs1JLT7EaAr03kRmKdHkfGAaySuJNzQ2MTOyNDI3tDAy NlcS5338f12YkEB6YklqdmpqQWoRTB8TB6dUA2NQYZ9v6eszF13aUjz/NFYcOGW93crpS6VB 2IqUgu02TxRWHBR5O/3+1ysOTe35l8TLbws7rH76P9/R02uTet23ZxM0HGcySbgxL9bPSf7S o3mqVUlpws4zYvHzMgXkDB5v57TgeWaZueGUleq5DjvbrBiT1hUvhSz/7Va/rlhzUKYmSEtj thJLcUaioRZzUXEiAOCnYpDrAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dan, On 2016년 02월 04일 20:36, Dan Carpenter wrote: > The info->status[] array has 3 elements. We are using size > MAX77843_MUIC_IRQ_NUM (16) instead of MAX77843_MUIC_STATUS_NUM (3) as > intended. > > Fixes: 135d9f7d135a ('extcon: max77843: Clear IRQ bits state before request IRQ') > Signed-off-by: Dan Carpenter > --- > This is from static analysis and *NOT TESTED*. Please review carefully. > > diff --git a/drivers/extcon/extcon-max77843.c b/drivers/extcon/extcon-max77843.c > index 7bbc300..b188bd6 100644 > --- a/drivers/extcon/extcon-max77843.c > +++ b/drivers/extcon/extcon-max77843.c > @@ -806,7 +806,7 @@ static int max77843_muic_probe(struct platform_device *pdev) > /* Clear IRQ bits before request IRQs */ > ret = regmap_bulk_read(max77843->regmap_muic, > MAX77843_MUIC_REG_INT1, info->status, > - MAX77843_MUIC_IRQ_NUM); > + MAX77843_MUIC_STATUS_NUM); > if (ret) { > dev_err(&pdev->dev, "Failed to Clear IRQ bits\n"); > goto err_muic_irq; > > The patch title should include the correct information of specific device. extcon: use correct size -> extcon: max77843: Use correct size for reading the interrupt register Applied it. Thanks, Chanwoo Choi