From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752782AbcBEJ6j (ORCPT ); Fri, 5 Feb 2016 04:58:39 -0500 Received: from mx2.suse.de ([195.135.220.15]:57599 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751572AbcBEJ6g (ORCPT ); Fri, 5 Feb 2016 04:58:36 -0500 Subject: Re: [PATCH] scripts/link-vmlinux.sh: force error on kallsyms failure To: Ard Biesheuvel References: <1454605779-30869-1-git-send-email-ard.biesheuvel@linaro.org> Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux@roeck-us.net, arnd@arndb.de, rusty@rustcorp.com.au From: Michal Marek Message-ID: <56B47249.1060603@suse.cz> Date: Fri, 5 Feb 2016 10:58:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1454605779-30869-1-git-send-email-ard.biesheuvel@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016-02-04 18:09, Ard Biesheuvel wrote: > - ${NM} -n ${1} | \ > - scripts/kallsyms ${kallsymopt} | \ > - ${CC} ${aflags} -c -o ${2} -x assembler-with-cpp - > + # capture the return code of scripts/kallsyms in $RC > + local RC=`(${NM} -n ${1} | \ > + (scripts/kallsyms ${kallsymopt}; echo $? 1>&3) | \ > + ${CC} ${aflags} -c -o ${2} -x assembler-with-cpp -) 3>&1` > + > + [ $RC -eq 0 ] This now ignores errors by the assembler (and makes the function hard to read). Please change it to use a temporary file. Michal