From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756034AbcBETyX (ORCPT ); Fri, 5 Feb 2016 14:54:23 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:58204 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751553AbcBETyV (ORCPT ); Fri, 5 Feb 2016 14:54:21 -0500 Subject: Re: [PATCH 2/6] arm64: dts: qcom: apq8016-sbc: add usb support To: Srinivas Kandagatla , Andy Gross References: <1454698819-13885-1-git-send-email-srinivas.kandagatla@linaro.org> <1454698880-13973-1-git-send-email-srinivas.kandagatla@linaro.org> Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org From: Stephen Boyd Message-ID: <56B4FDEB.2080202@codeaurora.org> Date: Fri, 5 Feb 2016 11:54:19 -0800 User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1454698880-13973-1-git-send-email-srinivas.kandagatla@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/05/2016 11:01 AM, Srinivas Kandagatla wrote: > + > + usb2513 { > + compatible = "smsc,usb3503"; > + reset-gpios = <&pm8916_gpios 3 GPIO_ACTIVE_LOW>; > + initial-mode = <1>; > + }; > + > + usb_id: usb-id { > + interrupt-parent = <&msmgpio>; > + compatible = "linux,extcon-usb-gpio"; > + id-gpio = <&msmgpio 121 GPIO_ACTIVE_HIGH>; > + pinctrl-names = "default"; > + pinctrl-0 = <&usb_id_default>; > + }; These are not on the SoC bus. Please move them to root. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project