From: Jyri Sarha <jsarha@ti.com>
To: Stephen Boyd <sboyd@codeaurora.org>,
Mike Turquette <mturquette@baylibre.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>
Subject: Re: [PATCH] clk: provider: Remove of_gpio_{gate,mux}_clk_setup() prototypes
Date: Sun, 7 Feb 2016 11:48:25 +0200 [thread overview]
Message-ID: <56B712E9.3020705@ti.com> (raw)
In-Reply-To: <1454830926-10434-1-git-send-email-sboyd@codeaurora.org>
On 02/07/16 09:42, Stephen Boyd wrote:
> These functions either never existed or were only used in
> OF_CLK_DECLARE() macros. Remove the dead prototypes.
>
Yes, they were used by OF_CLK_DECLARE() macros. I originally made the
of_gpio_clk_gate_setup() non static just because the other basic clocks
were implemented the same way. Actually I do not follow why the
functions needed to be non static in the first place. Surely the
declarations can go now after the conversion to a platform driver.
Acked-by: Jyri Sarha <jsarha@ti.com>
> Cc: Jyri Sarha <jsarha@ti.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
> include/linux/clk-provider.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h
> index 9c3a18c1a984..fce7f027f8a7 100644
> --- a/include/linux/clk-provider.h
> +++ b/include/linux/clk-provider.h
> @@ -626,8 +626,6 @@ struct clk *clk_register_gpio_gate(struct device *dev, const char *name,
> const char *parent_name, unsigned gpio, bool active_low,
> unsigned long flags);
>
> -void of_gpio_clk_gate_setup(struct device_node *node);
> -
> /**
> * struct clk_gpio_mux - gpio controlled clock multiplexer
> *
> @@ -643,8 +641,6 @@ struct clk *clk_register_gpio_mux(struct device *dev, const char *name,
> const char * const *parent_names, u8 num_parents, unsigned gpio,Acked-by:
> bool active_low, unsigned long flags);
>
> -void of_gpio_mux_clk_setup(struct device_node *node);
> -
> /**
> * clk_register - allocate a new clock, register it and return an opaque cookie
> * @dev: device that is registering this clock
>
next prev parent reply other threads:[~2016-02-07 9:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-07 7:42 [PATCH] clk: provider: Remove of_gpio_{gate,mux}_clk_setup() prototypes Stephen Boyd
2016-02-07 9:48 ` Jyri Sarha [this message]
2016-02-08 22:16 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B712E9.3020705@ti.com \
--to=jsarha@ti.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).