From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753676AbcBGJsc (ORCPT ); Sun, 7 Feb 2016 04:48:32 -0500 Received: from comal.ext.ti.com ([198.47.26.152]:48315 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751066AbcBGJsa (ORCPT ); Sun, 7 Feb 2016 04:48:30 -0500 Subject: Re: [PATCH] clk: provider: Remove of_gpio_{gate,mux}_clk_setup() prototypes To: Stephen Boyd , Mike Turquette References: <1454830926-10434-1-git-send-email-sboyd@codeaurora.org> CC: , From: Jyri Sarha Message-ID: <56B712E9.3020705@ti.com> Date: Sun, 7 Feb 2016 11:48:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1454830926-10434-1-git-send-email-sboyd@codeaurora.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/07/16 09:42, Stephen Boyd wrote: > These functions either never existed or were only used in > OF_CLK_DECLARE() macros. Remove the dead prototypes. > Yes, they were used by OF_CLK_DECLARE() macros. I originally made the of_gpio_clk_gate_setup() non static just because the other basic clocks were implemented the same way. Actually I do not follow why the functions needed to be non static in the first place. Surely the declarations can go now after the conversion to a platform driver. Acked-by: Jyri Sarha > Cc: Jyri Sarha > Signed-off-by: Stephen Boyd > --- > include/linux/clk-provider.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h > index 9c3a18c1a984..fce7f027f8a7 100644 > --- a/include/linux/clk-provider.h > +++ b/include/linux/clk-provider.h > @@ -626,8 +626,6 @@ struct clk *clk_register_gpio_gate(struct device *dev, const char *name, > const char *parent_name, unsigned gpio, bool active_low, > unsigned long flags); > > -void of_gpio_clk_gate_setup(struct device_node *node); > - > /** > * struct clk_gpio_mux - gpio controlled clock multiplexer > * > @@ -643,8 +641,6 @@ struct clk *clk_register_gpio_mux(struct device *dev, const char *name, > const char * const *parent_names, u8 num_parents, unsigned gpio,Acked-by: > bool active_low, unsigned long flags); > > -void of_gpio_mux_clk_setup(struct device_node *node); > - > /** > * clk_register - allocate a new clock, register it and return an opaque cookie > * @dev: device that is registering this clock >