From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755380AbcBHH03 (ORCPT ); Mon, 8 Feb 2016 02:26:29 -0500 Received: from mx2.suse.de ([195.135.220.15]:56367 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752988AbcBHH01 (ORCPT ); Mon, 8 Feb 2016 02:26:27 -0500 Subject: Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional To: James Bottomley , Christoph Hellwig References: <1454783624.2809.6.camel@HansenPartnership.com> <20160207092241.GA15331@lst.de> <1454861040.2329.4.camel@HansenPartnership.com> Cc: "linux-nvme@lists.infradead.org" , linux-block@vger.kernel.org, linux-scsi , linux-kernel , Jens Axboe From: Hannes Reinecke Message-ID: <56B84321.3010308@suse.de> Date: Mon, 8 Feb 2016 08:26:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1454861040.2329.4.camel@HansenPartnership.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/07/2016 05:04 PM, James Bottomley wrote: > On Sun, 2016-02-07 at 10:22 +0100, Christoph Hellwig wrote: >> Keith said it should be on by default, and I promised him to change >> it once we run into problems, which I guess this counts as. >> >> But just curious: what distro are you using? Upstream systemd >> explicitly rejected using scsi_id for NVMe here: >> >> https://github.com/systemd/systemd/issues/1453 >> >> and all my test systems don't do this either. > > This was SUSE (in my case, openSUSE Leap). I just checked the source > package; they patch the by-id rules back in for NVME: > > # PATCH-FIX-SUSE 1101-rules-persistent-device-names-for-NVMe-devices.patch (bsc#944132) > Patch1101: 1101-rules-persistent-device-names-for-NVMe-devices.patch > > The bugzilla is giving access denied for bug id 944132, so it's likely > some proprietary vendor problem. The patch has no preamble, so it's > hard to tell what they were thinking. > They didn't think at all. That abovementioned bug just states 'by-id symlinks for NVMe drives are missing'. And they fixed it by add the respective rules (using sg_inq) to udev. There's no mentioning of any NVMe specific sysfs attributes whatsoever. Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)