From: Laxman Dewangan <ldewangan@nvidia.com>
To: <lee.jones@linaro.org>, <alexandre.belloni@free-electrons.com>,
<k.kozlowski@samsung.com>, <javier@osg.samsung.com>,
<broonie@kernel.org>, <gregkh@linuxfoundation.org>,
<a.zummo@towertech.it>
Cc: <cw00.choi@samsung.com>, <linux-kernel@vger.kernel.org>,
<rtc-linux@googlegroups.com>
Subject: Re: [PATCH V4 6/6] rtc: max77686: move initialisation of rtc regmap, irq chip locally
Date: Mon, 8 Feb 2016 15:50:06 +0530 [thread overview]
Message-ID: <56B86BD6.2010607@nvidia.com> (raw)
In-Reply-To: <1454769447-785-7-git-send-email-ldewangan@nvidia.com>
On Saturday 06 February 2016 08:07 PM, Laxman Dewangan wrote:
> - ret = devm_request_threaded_irq(&pdev->dev, info->virq, NULL,
> - max77686_rtc_alarm_irq, 0,
> - "rtc-alarm1", info);
> - if (ret < 0)
> + ret = request_threaded_irq(info->virq, NULL, max77686_rtc_alarm_irq, 0,
> + "rtc-alarm1", info);
> + if (ret < 0) {
> dev_err(&pdev->dev, "Failed to request alarm IRQ: %d: %d\n",
> info->virq, ret);
> + goto err_rtc;
> + }
> +
> + return 0;
>
> err_rtc:
Oops.. I wish I should have called regmap_irq_put_virq(info->virq); here.
Please let me know if I can respin this patch only instead of entire series.
next prev parent reply other threads:[~2016-02-08 10:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-06 14:37 [PATCH V4 0/6] rtc: max77686: make max77686 rtc driver as IP driver Laxman Dewangan
2016-02-06 14:37 ` [PATCH V4 1/6] regmap: irq: add apis to unmap the mapped irq Laxman Dewangan
2016-02-08 14:55 ` Mark Brown
2016-02-08 16:38 ` Laxman Dewangan
2016-02-08 16:59 ` Mark Brown
2016-02-08 16:56 ` Laxman Dewangan
2016-02-08 18:19 ` Mark Brown
2016-02-09 5:16 ` Laxman Dewangan
2016-02-09 9:08 ` Laxman Dewangan
2016-02-09 11:27 ` Mark Brown
2016-02-09 11:21 ` Laxman Dewangan
2016-02-06 14:37 ` [PATCH V4 2/6] rtc: max77686: fix checkpatch error Laxman Dewangan
2016-02-06 14:37 ` [PATCH V4 3/6] rtc: max77686: use rtc regmap to access RTC registers Laxman Dewangan
2016-02-06 14:37 ` [PATCH V4 4/6] rtc: max77686: avoid reference of parent device info multiple places Laxman Dewangan
2016-02-06 14:37 ` [PATCH V4 5/6] mfd: max77686: do not set i2c client data for rtc i2c client Laxman Dewangan
2016-02-06 14:37 ` [PATCH V4 6/6] rtc: max77686: move initialisation of rtc regmap, irq chip locally Laxman Dewangan
2016-02-08 10:20 ` Laxman Dewangan [this message]
2016-02-08 10:42 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B86BD6.2010607@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=javier@osg.samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).