From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752723AbcBHKbl (ORCPT <rfc822;w@1wt.eu>);
	Mon, 8 Feb 2016 05:31:41 -0500
Received: from hqemgate16.nvidia.com ([216.228.121.65]:16929 "EHLO
	hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752211AbcBHKbj (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 8 Feb 2016 05:31:39 -0500
X-PGP-Universal: processed;
	by hqnvupgp07.nvidia.com on Mon, 08 Feb 2016 02:31:09 -0800
Message-ID: <56B86BD6.2010607@nvidia.com>
Date: Mon, 8 Feb 2016 15:50:06 +0530
From: Laxman Dewangan <ldewangan@nvidia.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0
MIME-Version: 1.0
To: <lee.jones@linaro.org>, <alexandre.belloni@free-electrons.com>,
        <k.kozlowski@samsung.com>, <javier@osg.samsung.com>,
        <broonie@kernel.org>, <gregkh@linuxfoundation.org>,
        <a.zummo@towertech.it>
CC: <cw00.choi@samsung.com>, <linux-kernel@vger.kernel.org>,
        <rtc-linux@googlegroups.com>
Subject: Re: [PATCH V4 6/6] rtc: max77686: move initialisation of rtc regmap,
 irq chip locally
References: <1454769447-785-1-git-send-email-ldewangan@nvidia.com> <1454769447-785-7-git-send-email-ldewangan@nvidia.com>
In-Reply-To: <1454769447-785-7-git-send-email-ldewangan@nvidia.com>
X-Originating-IP: [10.19.65.30]
X-ClientProxiedBy: DRUKMAIL102.nvidia.com (10.25.59.20) To
 bgmail102.nvidia.com (10.25.59.11)
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On Saturday 06 February 2016 08:07 PM, Laxman Dewangan wrote:
> -	ret = devm_request_threaded_irq(&pdev->dev, info->virq, NULL,
> -					max77686_rtc_alarm_irq, 0,
> -					"rtc-alarm1", info);
> -	if (ret < 0)
> +	ret = request_threaded_irq(info->virq, NULL, max77686_rtc_alarm_irq, 0,
> +				   "rtc-alarm1", info);
> +	if (ret < 0) {
>   		dev_err(&pdev->dev, "Failed to request alarm IRQ: %d: %d\n",
>   			info->virq, ret);
> +		goto err_rtc;
> +	}
> +
> +	return 0;
>   
>   err_rtc:

Oops.. I wish I should have called regmap_irq_put_virq(info->virq); here.

Please let me know if I can respin this patch only instead of entire series.