linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Frias <sf84@laposte.net>
To: "Måns Rullgård" <mans@mansr.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	mason <slash.tmp@free.fr>
Subject: [PATCH v5] net: ethernet: nb8800: support fixed-link DT node
Date: Mon, 08 Feb 2016 11:23:04 +0100	[thread overview]
Message-ID: <56B86C88.5090504@laposte.net> (raw)
In-Reply-To: <yw1xbn7vgoux.fsf@unicorn.mansr.com>


Under some circumstances, for example when connecting
to a switch:

https://stackoverflow.com/questions/31046172/device-tree-for-phy-less-connection-to-a-dsa-switch

the ethernet port will not be connected to a PHY.
In that case a "fixed-link" DT node can be used to replace it.

This patch adds support for the "fixed-link" node to the
nb8800 driver.

Signed-off-by: Sebastian Frias <sf84@laposte.net>
---
  drivers/net/ethernet/aurora/nb8800.c | 14 +++++++++++++-
  1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/aurora/nb8800.c 
b/drivers/net/ethernet/aurora/nb8800.c
index ecc4a33..e1fb071 100644
--- a/drivers/net/ethernet/aurora/nb8800.c
+++ b/drivers/net/ethernet/aurora/nb8800.c
@@ -1460,7 +1460,19 @@ static int nb8800_probe(struct platform_device *pdev)
  		goto err_disable_clk;
  	}

-	priv->phy_node = of_parse_phandle(pdev->dev.of_node, "phy-handle", 0);
+	if (of_phy_is_fixed_link(pdev->dev.of_node)) {
+		ret = of_phy_register_fixed_link(pdev->dev.of_node);
+		if (ret < 0) {
+			dev_err(&pdev->dev, "bad fixed-link spec\n");
+			goto err_free_bus;
+		}
+		priv->phy_node = of_node_get(pdev->dev.of_node);
+	}
+
+	if (!priv->phy_node)
+		priv->phy_node = of_parse_phandle(pdev->dev.of_node,
+						  "phy-handle", 0);
+
  	if (!priv->phy_node) {
  		dev_err(&pdev->dev, "no PHY specified\n");
  		ret = -ENODEV;
-- 
2.1.4

  reply	other threads:[~2016-02-08 10:23 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-05 13:31 [PATCH] net: ethernet: support "fixed-link" DT node on nb8800 driver Sebastian Frias
2016-02-05 13:39 ` Måns Rullgård
2016-02-05 13:49   ` [PATCH v2] net: ethernet: support "fixed-link" DT key/node " Sebastian Frias
2016-02-05 13:58     ` Måns Rullgård
2016-02-05 14:08       ` Sebastian Frias
2016-02-05 14:13         ` Måns Rullgård
2016-02-05 14:22           ` [PATCH v3] net: ethernet: support "fixed-link" DT node " Sebastian Frias
2016-02-05 14:34             ` Måns Rullgård
2016-02-05 14:56               ` Sebastian Frias
2016-02-05 15:08                 ` Måns Rullgård
2016-02-05 15:20                   ` Sebastian Frias
2016-02-05 15:26                     ` Måns Rullgård
2016-02-08 10:23                       ` Sebastian Frias [this message]
2016-02-08 13:19                         ` [PATCH v5] net: ethernet: nb8800: support fixed-link DT node Måns Rullgård
2016-02-16 20:04                         ` David Miller
2016-02-08 10:34                       ` [PATCH v3] net: ethernet: support "fixed-link" DT node on nb8800 driver Sebastian Frias
2016-02-08 13:37                         ` Måns Rullgård
2016-02-08 14:11                           ` Mason
2016-02-08 14:38                             ` Sebastian Frias
2016-02-08 14:44                               ` Måns Rullgård
2016-02-08 14:32                           ` Sebastian Frias
2016-02-08 14:50                             ` Måns Rullgård
2016-02-05 14:56               ` [PATCH v4] net: ethernet: nb8800: support fixed-link DT node Sebastian Frias
2016-02-05 15:57   ` [PATCH] net: ethernet: support "fixed-link" DT node on nb8800 driver Andy Shevchenko
2016-02-05 15:58     ` Måns Rullgård

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56B86C88.5090504@laposte.net \
    --to=sf84@laposte.net \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mans@mansr.com \
    --cc=netdev@vger.kernel.org \
    --cc=slash.tmp@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).