From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751435AbcBHLRL (ORCPT ); Mon, 8 Feb 2016 06:17:11 -0500 Received: from foss.arm.com ([217.140.101.70]:59691 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750860AbcBHLRI (ORCPT ); Mon, 8 Feb 2016 06:17:08 -0500 Message-ID: <56B87928.7020803@arm.com> Date: Mon, 08 Feb 2016 11:16:56 +0000 From: Vladimir Murzin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Greg KH CC: arnd@arndb.de, linux@arm.linux.org.uk, daniel.lezcano@linaro.org, tglx@linutronix.de, u.kleine-koenig@pengutronix.de, andy.shevchenko@gmail.com, mark.rutland@arm.com, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, jslaby@suse.cz, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-serial@vger.kernel.org, linux-api@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 04/10] serial: mps2-uart: add MPS2 UART driver References: <1454413199-26573-1-git-send-email-vladimir.murzin@arm.com> <1454413199-26573-5-git-send-email-vladimir.murzin@arm.com> <20160207071154.GA32017@kroah.com> In-Reply-To: <20160207071154.GA32017@kroah.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/02/16 07:11, Greg KH wrote: >> + >> +#define SERIAL_NAME "ttyS" > > You can't be "ttyS", there's already a serial port named that, please > use a unique name and a new major/minor number (dynamic ideally). > Hi Greg, I did s/ttyMPS/ttyS per your request for v1 [1]. I'm fine to change it back if you prefer that, but I'd be glad to know what I've been missing? [1] https://lkml.org/lkml/2015/12/13/8 Thanks Vladimir > thanks, > > greg k-h > >