From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751678AbcBHLWH (ORCPT <rfc822;w@1wt.eu>);
	Mon, 8 Feb 2016 06:22:07 -0500
Received: from smtp311.phy.lolipop.jp ([210.157.22.79]:34311 "EHLO
	smtp311.phy.lolipop.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750818AbcBHLWF (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 8 Feb 2016 06:22:05 -0500
Subject: Re: [PATCH] ALSA: firewire-digi00x: Drop bogus const type qualifier
 on dot_scrt()
To: Geert Uytterhoeven <geert@linux-m68k.org>, Takashi Iwai <tiwai@suse.com>
References: <1454854455-20894-1-git-send-email-geert@linux-m68k.org>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        Damien Zammit <damien@zamaudio.com>, Robin Gareus <robin@gareus.org>
From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
X-Enigmail-Draft-Status: N1110
Message-ID: <56B87A58.6090304@sakamocchi.jp>
Date: Mon, 8 Feb 2016 20:22:00 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <1454854455-20894-1-git-send-email-geert@linux-m68k.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Feb 7 2016 23:14, Geert Uytterhoeven wrote:
> sound/firewire/digi00x/amdtp-dot.c:67: warning: type qualifiers ignored on function return type
> 
> Drop the bogus "const" type qualifier on the return type of dot_scrt()
> to fix this.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Yep. It came from original code[1] and I overlooked.

Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>

> ---
>  sound/firewire/digi00x/amdtp-dot.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/firewire/digi00x/amdtp-dot.c b/sound/firewire/digi00x/amdtp-dot.c
> index b02a5e8cad448c40..0ac92aba5bc1c9a4 100644
> --- a/sound/firewire/digi00x/amdtp-dot.c
> +++ b/sound/firewire/digi00x/amdtp-dot.c
> @@ -63,7 +63,7 @@ struct amdtp_dot {
>  #define BYTE_PER_SAMPLE (4)
>  #define MAGIC_DOT_BYTE (2)
>  #define MAGIC_BYTE_OFF(x) (((x) * BYTE_PER_SAMPLE) + MAGIC_DOT_BYTE)
> -static const u8 dot_scrt(const u8 idx, const unsigned int off)
> +static u8 dot_scrt(const u8 idx, const unsigned int off)
>  {
>  	/*
>  	 * the length of the added pattern only depends on the lower nibble

Thanks

[1] https://github.com/x42/003amdtp


Takashi Sakamoto