From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752724AbcBHMXX (ORCPT ); Mon, 8 Feb 2016 07:23:23 -0500 Received: from smtprelay2.synopsys.com ([198.182.60.111]:39018 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751552AbcBHMXW (ORCPT ); Mon, 8 Feb 2016 07:23:22 -0500 Subject: Re: [PATCH 6/9] ARC: clocksource: DT based probe To: Daniel Lezcano , , , "Noam Camus" References: <1454410739-24444-1-git-send-email-vgupta@synopsys.com> <1454410739-24444-7-git-send-email-vgupta@synopsys.com> <56B885B2.6060408@linaro.org> CC: Newsgroups: gmane.linux.kernel,gmane.linux.kernel.arc From: Vineet Gupta Message-ID: <56B888A8.5020306@synopsys.com> Date: Mon, 8 Feb 2016 17:53:04 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56B885B2.6060408@linaro.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.12.197.208] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 08 February 2016 05:40 PM, Daniel Lezcano wrote: > On 02/02/2016 11:58 AM, Vineet Gupta wrote: >> - Remove explicit clocksource setup and let it be done by OF framework >> by defining CLOCKSOURCE_OF_DECLARE() for various timers >> >> - This allows multiple clocksources to be potentially registered >> simultaneouly: previously we could only do one - as all of them had >> same arc_counter_setup() routine for registration >> >> - Setup routines also ensure that the underlying timer actually exists. >> >> - Remove some of the panic() calls if underlying timer is NOT detcted as >> a fallback clocksource might still be available >> 1. If GRFC doesn't exist, jiffies clocksource gets registered anyways >> 2. if RTC doesn't exist, TIMER1 cetainly will take over (as it is >> always present) >> >> Cc: Daniel Lezcano >> Signed-off-by: Vineet Gupta > > May be it is time to move these drivers into the drivers/clocksource directory > where they belong to. I suppose we could, but that is only possible after this round of "moderization", i.e. usage of CLOCKSOURCE_OF_DECLARE() et al. Plus the move will require a bunch of mechanical crap such as read_aux_reg() which only ARC defines (similar to headaches Noam had for his clksrc). So if we could agree on the sanity of this round of changes, I can work towards the imminent move into drivers. Thx, -Vineet