From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752932AbcBHMiR (ORCPT ); Mon, 8 Feb 2016 07:38:17 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:47047 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751976AbcBHMiQ (ORCPT ); Mon, 8 Feb 2016 07:38:16 -0500 X-AuditID: cbfec7f4-f79026d00000418a-57-56b88c35241f Subject: Re: [PATCH] drm/exynos: dp: Fix panel and bridge lookup logic To: Javier Martinez Canillas , linux-kernel@vger.kernel.org, Inki Dae References: <1454080171-23769-1-git-send-email-javier@osg.samsung.com> <56B88418.7090106@osg.samsung.com> Cc: Kukjin Kim , Krzysztof Kozlowski , Seung-Woo Kim , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, Kyungmin Park , Jingoo Han , David Airlie , Joonyoung Shim , linux-arm-kernel@lists.infradead.org From: Marek Szyprowski Message-id: <56B88C33.8060808@samsung.com> Date: Mon, 08 Feb 2016 13:38:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <56B88418.7090106@osg.samsung.com> Content-type: text/plain; charset=utf-8; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpnkeLIzCtJLcpLzFFi42I5/e/4NV3Tnh1hBn/XMVr0njvJZHHl63s2 i0n3J7BYvHm7hslixZeZ7BYv7l1ksXj9wtCi//FrZouzTW/YLTY9vsZqcXnXHDaLGef3MVnM mPySzYHXY+esu+wem1Z1snls//aA1eN+93Emj81L6j229APF+7asYvT4vEkugCOKyyYlNSez LLVI3y6BK6PvXTtrwXGuis23mtgaGLdzdDFyckgImEj8azjHDGGLSVy4t56ti5GLQ0hgKaPE yu1/mSGc54wS1689YwSpEhZwk7gw9QxrFyMHh4hAmcTzdREgYSGBbImP3y+ANTMLtDJLHFi+ gB0kwSZgKNH1tosNxOYV0JLYufseK4jNIqAq8X7FSrAaUYEYiYudR5ggagQlfky+xwJicwro S7RufwNWwyxgJvHl5WFWCFteYvOat8wTGAVmIWmZhaRsFpKyBYzMqxhFU0uTC4qT0nMN9YoT c4tL89L1kvNzNzFCoufLDsbFx6wOMQpwMCrx8FZ0bA8TYk0sK67MPcQowcGsJMLr07AjTIg3 JbGyKrUoP76oNCe1+BCjNAeLkjjv3F3vQ4QE0hNLUrNTUwtSi2CyTBycUg2Mq+veXKn9xDep xjloi1guo8wuCdf1jZveCXtv9twc9tpZZYOgxcmThxg+TbHZ/uVCS5y/9vnfHu/+Bjz/JTEp sOp5nMivL/pLLrseXjn/6iYL0+N5uvMLHvhW7FtyJup+pXm2zbfuU+eC4mZnZh7UPCryKvKl 8+PaRz189svUxc8dNu76qFZ1VImlOCPRUIu5qDgRACbyPtOaAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Javier, On 2016-02-08 13:03, Javier Martinez Canillas wrote: > Hello Inki, > > On 01/29/2016 12:09 PM, Javier Martinez Canillas wrote: >> Commit a9fa852886fd ("drm/exynos: dp: add of_graph dt binding support >> for panel") made the Exynos DP DT binding more consistent since the OF >> graph could be used to lookup either a panel or a bridge device node. >> >> Before that commit, a panel would be looked up using a phandle and a >> bridge using the OF graph which made the DT binding not consistent. >> >> But the patch broke the later case since not finding a panel dev node >> would cause the driver's to do a probe deferral instead of attempting >> to lookup a bridge device node associated with the remote endpoint. >> >> So instead of returning a -EPROBE_DEFER if a panel is not found, check >> if there's a bridge and only do a probe deferral if both aren't found. >> >> Fixes: a9fa852886fd ("drm/exynos: dp: add of_graph dt binding support >> for panel") >> Signed-off-by: Javier Martinez Canillas >> > > Any comments about this patch? It is needed to have display working on > machines with a bridge chip again so it should be pushed to -rc ASAP. Please check v4.5-rc3, this patch is already merged there. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland