From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752617AbcBHOLf (ORCPT ); Mon, 8 Feb 2016 09:11:35 -0500 Received: from foss.arm.com ([217.140.101.70]:32816 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751947AbcBHOLe (ORCPT ); Mon, 8 Feb 2016 09:11:34 -0500 Subject: Re: [PATCH 1/6] irqchip: add the Alpine MSIX interrupt controller To: Antoine Tenart References: <1454922971-17405-1-git-send-email-antoine.tenart@free-electrons.com> <1454922971-17405-2-git-send-email-antoine.tenart@free-electrons.com> <56B86391.1030609@arm.com> <20160208140429.GF4117@kwain> Cc: tglx@linutronix.de, jason@lakedaemon.net, tsahee@annapurnalabs.com, rshitrit@annapurnalabs.com, thomas.petazzoni@free-electrons.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: Marc Zyngier Organization: ARM Ltd Message-ID: <56B8A213.2020704@arm.com> Date: Mon, 8 Feb 2016 14:11:31 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.5.0 MIME-Version: 1.0 In-Reply-To: <20160208140429.GF4117@kwain> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/02/16 14:04, Antoine Tenart wrote: > Hi Marc, > > On Mon, Feb 08, 2016 at 09:44:49AM +0000, Marc Zyngier wrote: >> On 08/02/16 09:16, Antoine Tenart wrote: >>> + >>> +static struct msi_domain_info alpine_msix_domain_info = { >>> + .flags = MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS | >>> + MSI_FLAG_PCI_MSIX, >> >> You can probably add MSI_FLAG_PCI_MSI > > Are you sure such a flag is available? (Or am I missing something > obvious?). No, I'm just confused (first patch in the morning, what did you expect?). It looks like we consider single MSI as a given, please ignore my rambling... Thanks, M. -- Jazz is not dead. It just smells funny...