From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753742AbcBHObE (ORCPT ); Mon, 8 Feb 2016 09:31:04 -0500 Received: from mail-wm0-f51.google.com ([74.125.82.51]:36037 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753303AbcBHOa7 (ORCPT ); Mon, 8 Feb 2016 09:30:59 -0500 Subject: Re: [PATCH v2] clocksource/arm_arch_timer: Enable and verify MMIO access To: Robin Murphy , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <71bf617f4083b116b2aeab24f13fc5fed99a816f.1454327031.git.robin.murphy@arm.com> Cc: tglx@linutronix.de, mark.rutland@arm.com, sboyd@codeaurora.org From: Daniel Lezcano Message-ID: <56B8A6A0.4080704@linaro.org> Date: Mon, 8 Feb 2016 15:30:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <71bf617f4083b116b2aeab24f13fc5fed99a816f.1454327031.git.robin.murphy@arm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/01/2016 01:00 PM, Robin Murphy wrote: > So far, we have been blindly assuming that having access to a > memory-mapped timer frame implies that the individual elements of that > frame frame are already enabled. Whilst it's the firmware's job to give > us non-secure access to frames in the first place, we should not rely > on implementations always being generous enough to also configure CNTACR > for those non-secure frames (e.g. [1]). > > Explicitly enable feature-level access per-frame, and verify that the > access we want is really implemented before trying to make use of it. > > [1]:https://github.com/ARM-software/tf-issues/issues/170 > > Signed-off-by: Robin Murphy > --- Applied to my tree for 4.6. Thanks - Daniel