From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754751AbcBHPTb (ORCPT ); Mon, 8 Feb 2016 10:19:31 -0500 Received: from mailapp01.imgtec.com ([195.59.15.196]:45566 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751881AbcBHPTY (ORCPT ); Mon, 8 Feb 2016 10:19:24 -0500 Message-ID: <56B8B220.9060401@imgtec.com> Date: Mon, 8 Feb 2016 15:20:00 +0000 From: James Hartley User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121028 Thunderbird/16.0.2 MIME-Version: 1.0 To: Philipp Zabel CC: , Damien Horsley Subject: Re: [PATCH] reset: img: Make reset_control_ops const References: <1454938123-9704-1-git-send-email-p.zabel@pengutronix.de> In-Reply-To: <1454938123-9704-1-git-send-email-p.zabel@pengutronix.de> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.167.85] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/08/16 13:28, Philipp Zabel wrote: > The pistachio_reset_ops structure is never modified. Make it const. > > Signed-off-by: Philipp Zabel > --- > drivers/reset/reset-pistachio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/reset/reset-pistachio.c b/drivers/reset/reset-pistachio.c > index b31cdb0..72a97a1 100644 > --- a/drivers/reset/reset-pistachio.c > +++ b/drivers/reset/reset-pistachio.c > @@ -97,7 +97,7 @@ static int pistachio_reset_deassert(struct reset_controller_dev *rcdev, > mask, 0); > } > > -static struct reset_control_ops pistachio_reset_ops = { > +static const struct reset_control_ops pistachio_reset_ops = { > .assert = pistachio_reset_assert, > .deassert = pistachio_reset_deassert, > }; Acked-by: James Hartley