From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932245AbcBHPog (ORCPT ); Mon, 8 Feb 2016 10:44:36 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:24713 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932220AbcBHPod (ORCPT ); Mon, 8 Feb 2016 10:44:33 -0500 Subject: Re: [PATCH v2 2/2] xen/scsiback: avoid warnings when adding multiple LUNs to a domain To: Juergen Gross , linux-kernel@vger.kernel.org, xen-devel@lists.xen.org, konrad.wilk@oracle.com, david.vrabel@citrix.com References: <1454941819-24513-1-git-send-email-jgross@suse.com> <1454941819-24513-3-git-send-email-jgross@suse.com> Cc: stable@vger.kernel.org From: Boris Ostrovsky Message-ID: <56B8B7D5.4090506@oracle.com> Date: Mon, 8 Feb 2016 10:44:21 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1454941819-24513-3-git-send-email-jgross@suse.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/08/2016 09:30 AM, Juergen Gross wrote: > When adding more than one LUN to a frontend a warning for a failed > assignment is issued in dom0 for each already existing LUN. Avoid this > warning by checking for a LUN already existing when existence is > allowed (scsiback_do_add_lun() called with try == 1). > > As the LUN existence check is needed now for a third time, factor it > out into a function. This in turn leads to a more or less complete > rewrite of scsiback_del_translation_entry() which will now return a > proper error code in case of failure. > > Signed-off-by: Juergen Gross > Cc: stable@vger.kernel.org Reviewed-by: Boris Ostrovsky