From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755205AbcBHQq0 (ORCPT ); Mon, 8 Feb 2016 11:46:26 -0500 Received: from smtp02.citrix.com ([66.165.176.63]:36868 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755037AbcBHQqX (ORCPT ); Mon, 8 Feb 2016 11:46:23 -0500 X-IronPort-AV: E=Sophos;i="5.22,416,1449532800"; d="scan'208";a="336796742" Subject: Re: [Xen-devel] [PATCH v2 2/2] xen/scsiback: avoid warnings when adding multiple LUNs to a domain To: Juergen Gross , , , , , References: <1454941819-24513-1-git-send-email-jgross@suse.com> <1454941819-24513-3-git-send-email-jgross@suse.com> CC: From: David Vrabel Message-ID: <56B8C65C.1060901@citrix.com> Date: Mon, 8 Feb 2016 16:46:20 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.5.0 MIME-Version: 1.0 In-Reply-To: <1454941819-24513-3-git-send-email-jgross@suse.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/02/16 14:30, Juergen Gross wrote: > When adding more than one LUN to a frontend a warning for a failed > assignment is issued in dom0 for each already existing LUN. Avoid this > warning by checking for a LUN already existing when existence is > allowed (scsiback_do_add_lun() called with try == 1). > > As the LUN existence check is needed now for a third time, factor it > out into a function. This in turn leads to a more or less complete > rewrite of scsiback_del_translation_entry() which will now return a > proper error code in case of failure. > > Signed-off-by: Juergen Gross > Cc: stable@vger.kernel.org Avoiding warnings doesn't seem like a viable candidate for stable. Is there more to this patch than the description suggests? David