From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755117AbcBHQut (ORCPT ); Mon, 8 Feb 2016 11:50:49 -0500 Received: from mx2.suse.de ([195.135.220.15]:55031 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750922AbcBHQus (ORCPT ); Mon, 8 Feb 2016 11:50:48 -0500 Subject: Re: [Xen-devel] [PATCH v2 2/2] xen/scsiback: avoid warnings when adding multiple LUNs to a domain To: David Vrabel , linux-kernel@vger.kernel.org, xen-devel@lists.xen.org, konrad.wilk@oracle.com, boris.ostrovsky@oracle.com References: <1454941819-24513-1-git-send-email-jgross@suse.com> <1454941819-24513-3-git-send-email-jgross@suse.com> <56B8C65C.1060901@citrix.com> Cc: stable@vger.kernel.org From: Juergen Gross Message-ID: <56B8C765.4000707@suse.com> Date: Mon, 8 Feb 2016 17:50:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <56B8C65C.1060901@citrix.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/02/16 17:46, David Vrabel wrote: > On 08/02/16 14:30, Juergen Gross wrote: >> When adding more than one LUN to a frontend a warning for a failed >> assignment is issued in dom0 for each already existing LUN. Avoid this >> warning by checking for a LUN already existing when existence is >> allowed (scsiback_do_add_lun() called with try == 1). >> >> As the LUN existence check is needed now for a third time, factor it >> out into a function. This in turn leads to a more or less complete >> rewrite of scsiback_del_translation_entry() which will now return a >> proper error code in case of failure. >> >> Signed-off-by: Juergen Gross >> Cc: stable@vger.kernel.org > > Avoiding warnings doesn't seem like a viable candidate for stable. Is > there more to this patch than the description suggests? No. Should I resend without the Cc: stable? Juergen