From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753585AbcBHSO6 (ORCPT ); Mon, 8 Feb 2016 13:14:58 -0500 Received: from mail-bn1bon0075.outbound.protection.outlook.com ([157.56.111.75]:11854 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751327AbcBHSOz (ORCPT ); Mon, 8 Feb 2016 13:14:55 -0500 Authentication-Results: spf=none (sender IP is 165.204.84.222) smtp.mailfrom=amd.com; arndb.de; dkim=none (message not signed) header.d=none;arndb.de; dmarc=permerror action=none header.from=amd.com; X-WSS-ID: 0O28QOM-08-0P2-02 X-M-MSG: Subject: Re: [PATCH v2] ata: add AMD Seattle platform driver To: Arnd Bergmann References: <1452789071-4090-1-git-send-email-brijesh.singh@amd.com> <4743985.XZ7D12RurV@wuerfel> <56B0F786.9010504@amd.com> <3134806.iILWebdeN8@wuerfel> <56B4DA8B.2050609@amd.com> CC: , Tejun Heo , , , , Graeme Gregory From: Brijesh Singh Message-ID: <56B8DA7D.6010400@amd.com> Date: Mon, 8 Feb 2016 12:12:13 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <56B4DA8B.2050609@amd.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.222;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(428002)(377454003)(24454002)(199003)(189002)(479174004)(83506001)(64126003)(101416001)(36756003)(77096005)(4001350100001)(1220700001)(586003)(50986999)(65816999)(80316001)(110136002)(87266999)(50466002)(92566002)(54356999)(76176999)(189998001)(4326007)(2906002)(1096002)(6116002)(86362001)(3846002)(23746002)(230700001)(2950100001)(47776003)(65806001)(93886004)(5004730100002)(105586002)(33656002)(5008740100001)(87936001)(65956001)(106466001);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR12MB0710;H:atltwp02.amd.com;FPR:;SPF:None;MLV:sfv;A:1;MX:1;LANG:en; X-MS-Office365-Filtering-Correlation-Id: 0c2ab49f-9150-43b1-48db-08d330b3bce5 X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0710;2:yUIu2tdRZmG8usQbSpg60qdNiL3tpsh2V4Vp2JWAUigC6bgrAmlU7z99EN+LKmKn31/Rp9B8QMRvgX0ZK1QHZX7uf/sqm/KMkeDxduje8vz78c2ph8FxjbsBSgimpk75o5rjV5BCPN8TEXMqESdezahzDot+xYZA90MJhLqy78LnNxN0WJ1/1dECjLKkvXLo;3:XBl6Mv/IQZM7OO6DJN3cyiT1VzXht7pWx3bHCaAG7E3VorY2ByREbfpXsv3b778xMNxKI0SP3f8z6ZGKtFtyi7SRXEXD/DOhCwME20sjI6vUA0xKMkqwgNmCuEna9RoOtWdhmr/+Boff8BQxHJtZ9QkzzF6DR2bxr09kwqyukTF6TiwFAWweqDV5Vy8lkzJaKE9Y5OVqXnAPcnh/wii7fxxmrXryJm9drJCMzRriKV8=;25:G6MjYb7dwMOjAcv4WAiC5nE3Wl7YenV/oEo8ubeVuIUEYFeN+gU3w2jE6B7gI2p+0kUOHqYrVbOXl8HymnmpffFy2kH8Jzm/6w6QuKxlmeWROy335gUgQnLrAbu8UIfQ7qW/JjbFc+AJUaYIPqGYdhx/JEYXwJBNtoCPf81xxn7rqMU4RKrC5brgNu4TGmDKQzIn+fwz/0oxEzkW77G0EvFLedCmNbL19/lFNKfZQMCtWtjaNrovNyLWMVIaEnOlVrXHWinu6xxVbvJU4P8uRsXbnJM6sSd4d3pGVS0zJ4D9QxCYB8W61hGXhHt/PcYs X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR12MB0710; X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0710;20:+X4XJg35zFCaoghlnBTsSI5uJq/0UF08rWP3X8cjKEkW4DSCtoCQpt3Jy73ywkvNAk60AJLdQPWqizceM2s3+wYIfTExfD/iz10MnXZ0ZywT+8S8ZV9j0vd/AyBsxCTJKnZgqvoFzs25CyuvpQieWyDXqSBYYNACxNZNo+coIyj44Ev9k0PuDU7TKJgm9lHFN/BzVuOMC04KlKtzCKihbB+8J9RdNMfP+4OdeTOB5kUYYZRdEL7Q5NaOHmLKU1gUM1MUQhAjzfPj0bVQ7QJcpGTa0zmiEGC9QGbyyfw9Pok10Up/lUMlocpIwb7w03ga3thx5fw4JqCYQ/KDWf1bMjFeoYYxwyCUideuqOWkhjQfon7JiDZKDclGvVb7CzwtEupe3u8Ja0CyhDu2s6G64C8MM22fo550r5slJpkW8R8K8loC6MXVoMKf7uFlZBGyPfURsfpg976myZwk7vgULXTAThWdv21e86S9gJKGzd4D88clirHAM3rWOiO18Exz X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13018025)(13015025)(13017025)(13024025)(5005006)(13023025)(8121501046)(3002001)(10201501046);SRVR:BY2PR12MB0710;BCL:0;PCL:0;RULEID:;SRVR:BY2PR12MB0710; X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0710;4:QJ4knDpsdC2POcBN7jzSnJpVq/1aQ7p27CBYgFLyTF0CHVitDWEIqGTkjzAZ0IYvMA9C5hT9HPmpeDw+aTba3djmzWMVn/ZmAZeH47SgqGOC0G++FzgDXvw3nmJtgzeAh+TX7fXBr+6XDRD36084+UEKIOivGt3UQuG53TqA2d7Fw+xt5fG7PCUJKE97KcVSPJZFlA6NWEqv85UfwadBW6oLPg3X0EOeGURoFVBU7gpxBr0tMGfH3FcKcfgMUmqt53BOGjSonBOwZj24xEmXnz6pdjNaHTcQO5kzetHSgx0d+vcgIeWhUB/3mHHUhIQKdA8i20lCGxcXDhmf59M19PvSJEaT3qnXS/7vqsytSdtx6/VoYMM8d+DhCmypeaS1EJ3RiLAypENk66EmuofluLZi8geuAc479gywnvs+DasbeauC1BCBvlVFW3ZnrqFlrXUN1lbYOuFIE8xloK4bfQ== X-Forefront-PRVS: 084674B2CF X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BY2PR12MB0710;23:0YBjtYDVg6i+LneYM/81AoWIg3cet4PrIeF/c?= =?Windows-1252?Q?5zF1apmvTuc9lDVt57DIlJichkhI+jsGrxk4atJRLlJEVX9WSpPsBo55?= =?Windows-1252?Q?DFFa0nuFYDE5b9JmbkwxSFzQEQcPw8zIhL+/9nVjC2uWrx2u8DZK2tUl?= =?Windows-1252?Q?8RSuPGjeyc4ND/6MdUaS+1zO4rMQnVdOS4Uab0bbFEKjku4TW8vq7uvj?= =?Windows-1252?Q?hM375wdAb03qh/qFKcBKmuh2ZtUG/D7ekT4nGWLbPG/9gwXoszorDgcZ?= =?Windows-1252?Q?cVeG4rUqXhtOIcoiv4PBdGC9yGmbtuoycd4IDIO+UUE/BrzWEhpTGknD?= =?Windows-1252?Q?QwddbQBydGBCtnCsaA/KajrVQ/q70ffx25c8WQ9XJEKRH+IWxvcXPJG8?= =?Windows-1252?Q?2CNWXtQQRETBVOTzBOu31ax9Myo/puTI7EQ0dgw7V2F0EniXQhXNyfBW?= =?Windows-1252?Q?Ly7OjyM7s5WCfUW7JhdJV7gxq4Zm9xMvv21nkZHedNXtZYGa0VDu+9dI?= =?Windows-1252?Q?eHgA6WjeivKfMREJZ0LDp6RDbJjGn4J6nl72xKa17mNjQkr7twL3lpTk?= =?Windows-1252?Q?UPs+9JBDPkQnI+jETY9O7kmpyfrphetwkFFUb/pUkmGM/KteDPqZDOdf?= =?Windows-1252?Q?FKHEWGi6/JEPahLPHxuvYlcmmC0aY1GgyZ/BUUqzNd5tqk1NsVMNqxpM?= =?Windows-1252?Q?sGio3D9RzwuxvZ0h+XaI6vVuFewrFDiukBOex7p27h3w8CJqmSFCI1cR?= =?Windows-1252?Q?T9ax0Uacy3ASHSj6Vq2fgZo+tAidTg6H2QKHY0WLBaLyLuWV1TNuP3cR?= =?Windows-1252?Q?Setl7FIP1KaaFMPa6OW7mBndYQFN+4QX4mAKDjIqHYFjnjsd17Bt8xBY?= =?Windows-1252?Q?uDEFwpbnv2c6u1iB/rgb/f1INZAe+inp+fqR1p/CQED/kvXpYPJD+Lw+?= =?Windows-1252?Q?cv9Tq/sDTdIRgnqgQW64BGBETzBFS4N4fvVPTNTHQORJQ47RBIoe8s6H?= =?Windows-1252?Q?jhJEi7kLOoyhj8m8FJytrLEy3/R4mjLh0Hvmr6rIZDXQQs/mf7sfje3+?= =?Windows-1252?Q?OES6seYFlXsQWNpL4mJtFxZzjCeJdETet3aNoYFnqbrBDpAC6KzP+jvW?= =?Windows-1252?Q?iiDElXSS9hYm49fQJt4pad/2dC4JSf1pgbNuXkXOhFUu5sLWy8HKTPDF?= =?Windows-1252?Q?fzUYcgK4dkR6SYEIPVziwA++owVkYHJgfG0qjDlXlIEjbjNCJrZ?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0710;5:C4mK8jEzBEkBabhLV3IZ8n+7S9DHE04Ad6VyeIAAMj7wAvJwjS/BwTbQrKN52/qZYxdcNp1IPkW9l0qti2+F4+28wBqQT8Nq3vwH31KuhNbCfsSfmKKkH5W4yXfygATdlKCi1OPj4aLHOClfnJ7eSw==;24:VXTZatp5boSepPIo0OjWC4R3GnAWkAADMzmLtkHBWN0g50jfbQ1UFe6uOrgpscLOmhPxerl6vB6LbMGrpw9JLpaqOOQsc+6ogMuk1Ud05Ls=;20:MCj071WETg529REWGh1+4VDKKPbvT+N7Rcc0Q+S4He0RkI8ZjI/3/EJIpGnW/6/QkZm8AgnuOv316Oekpsiku6YJoVYFFebtkr62qbDLbjwvkYNd4rTEwBQYsOhweIt0aC57n9yDjDPZ6wsjKW4RfiSrLuQmpbDzXBk3PiRTuxwkPM0q/6j/dLTaN8yN9tmo9HB/YSfb5zq/GmNAKlxt/qNIZzrYargS4pNiaAW1d5D5hYceJ6JuLiFVSLwS0soT SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2016 18:14:50.7981 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.222];Helo=[atltwp02.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR12MB0710 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, On 02/05/2016 11:23 AM, Brijesh Singh wrote: > Hi, > >>> } >>> >>> Windows driver folks were okay to look at second resource field to map the SGPIO register and program the >>> registers to blink the LEDs. I think as per ACPI spec, its legal to pass more than one block in resource >>> template and since AML method is not mandatory for non standard enclosure management hence its entirely >>> possible that some BIOS vendors may not implement it at all. But if they implement and decide >>> to expose either AML method or register map but not both then Windows driver may break. >> >> I don't have access to the Windows source code. Is this in the >> architecture-independent part of their kernel, or only done on ARM64? >> How do they decide what the second memory range is for? >> >> If this is now a de-facto extension to the PCI_CLASS_STORAGE_SATA_AHCI binding, >> it should probably be put into the next version of the AHCI spec, and then >> there is no problem using it. >> > I don't have Windows code either and do not know the implementation details. I was told by the AMD folks > working on Windows drivers for Seattle that they do not need any changes in BIOS DSDT to get the LEDs blinking. > > This is not a de-facto extension of SATA_AHCI binding, you can call this method as a SoC hack to support the LEDs. > We are working with whatever BIOS is already available to enable the LEDs blinking. > I am not sure what I can do next, given the SoC and BIOS limitation it seems like platform driver is best choice to enable this feature. Do you have any review feedback on driver itself ? if not, then can we get this patch in? -Brijesh