From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756556AbcBHVjc (ORCPT ); Mon, 8 Feb 2016 16:39:32 -0500 Received: from mail-bl2on0097.outbound.protection.outlook.com ([65.55.169.97]:11269 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756276AbcBHVj3 (ORCPT ); Mon, 8 Feb 2016 16:39:29 -0500 Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=caviumnetworks.com; Message-ID: <56B90B09.7090500@caviumnetworks.com> Date: Mon, 8 Feb 2016 13:39:21 -0800 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Rob Herring CC: David Daney , Bjorn Helgaas , "linux-pci@vger.kernel.org" , Will Deacon , "linux-arm-kernel@lists.infradead.org" , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , David Daney Subject: Re: [PATCH v5 3/3] pci, pci-thunder-ecam: Add driver for ThunderX-pass1 on-chip devices References: <1454715675-17512-1-git-send-email-ddaney.cavm@gmail.com> <1454715675-17512-4-git-send-email-ddaney.cavm@gmail.com> <20160208195642.GA15103@rob-hp-laptop> <56B8FED6.1050804@caviumnetworks.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [64.2.3.194] X-ClientProxiedBy: BN1PR07CA0040.namprd07.prod.outlook.com (10.255.193.15) To SN1PR07MB2143.namprd07.prod.outlook.com (25.164.47.13) X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2143;2:7axRWTtA9GJ8L5oQ2RvuqZmfvjRzNQVrBx5BCIoHKGh4qBpxxcyWF5y9V1TMxY58ZdUxyt8KvFPVSsBiRP96QTGISfzy24G7ztXz9T2rZwcuJymkY+8RKrB6YKQQT3EzlbRHLQ0/5fYE9I/yPfLj4Q==;3:6TFtqBrvTNqtIm8vyew84OtNp58jLJQfLa5eFtYodJQaiDMCXeyoEWv2GGFE1yzuRywfN/wPLqDfRipFIIDMkVIn/nuuDSRKUGPE2llnO7W5JgjU7JIhtj1ktmCBO+5A;25:rX4p6kXXwaIwCh3TBqaafdHro7H82vu0voXLJ1HHoiwjgyRM7QggSWcI9jhhRBC6JxULPUm6bx5VbWyPrlEILLzVZDUDcsX3NRmJdKYvHkq4Iko+V70vgFjJBzwK3Wm3550cfVePD4RTlmE+IxzYty9/lB3u4XxRdomX3b5lZihjoqs0RLSZopkVdIat6iqWTDzYzWU6+D88hQNWb2qmpp8AeXkkoi0FdCnkm9R41VR1KeyXeMcPnbSqiB9NE6hKAp2FSO6Fh1g3ozkN8w0eyh1skcTZMw77um0+aFyALbdUAL9f5D3tBtQitW94ZBeD X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR07MB2143; X-MS-Office365-Filtering-Correlation-Id: 9b054c09-d6e5-4f70-4abb-08d330d0514a X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2143;20:Wc9lKlw46t9VPFAF0P1ehdtlxhDvovMJpgAU0ndgtD6o9w6oYIcm4wrzvfM+sz7A5bgjtsXEWXus10DEHvhFPEggAp8hryslbFo6hccLLDZp2+NHjM+yJFihhVmMrCAa0oiSeackqDlkV/JFF0SIy8tpDGHUCSLbbM5ASmTmKo2ZzBWsCh+/vOaqaRvYLvaBmr9T5BiqS70vnhUgMzcOyoQ/w0UM43y0zIczamxCrjA7OUYy+8/DMUsBovpVNejXSGUwGIPQZ4VO6W2OmmFcujMmExDZyHA+Yn8r5O6e2wCTf282mZbCWwJkXrlYQfO5fnC9XepVsR/wy75eZGHkEBUGmkJa0CEAlQmhEta8Y1OocNcMNRAHBqhjDjYqBPYrALsvL/66IBHhRXFhigansbY5iu/0tHInfkcRkJpAXjlcXa5yiiXjaiCHYp+ZIC17lwkhhn5Srg0RCbKWusGpF54XuiRhtYwLLwL4qQLAnWD4GrGHWwLBXEX+UoBZ55SmtHXPbLidDkESkWXmUVHBuGRMs6wih3tUGcReN4qaYTBiu5IQ+549E7+2olchgJLL+TPKx8iPDlBAue948A34851T+qZM8e6zWcLOujL4k98= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001);SRVR:SN1PR07MB2143;BCL:0;PCL:0;RULEID:;SRVR:SN1PR07MB2143; X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2143;4:lq2MwBZHmG78mmUYYq5GMgKUx3PzTll4PFUb3UdGGzap66k2uJ9V4qwd66M6sGRRWvL26lhhz0906D4W6sMGP7ygGFLQwlSs7Kc91D3kg2sCp4kkMz15uWvCep1HREUaFBkTzlstNsct3M8mRZ+CE+8ut8F2jfDYi28JaEq9CcIl6OyyuzGFmWeZDx/EqLcb9OjTmjgBSrYqUWpeVHNxSzmnEoO2wr3jHLtIzkQ0YfkrEaBKLiyYF5+iLvyvx/0R2ZN1Bkgx/bapuBNa9GDdrVpVT/7SK0bnhQq0sZszaWNX7OJgHniygev9WytWVGIZfqSfsZ0rMPYQH2VHQxzSFQR5uKk/FufYxXW25SUyjQ4R8YT7E8onrPGiSQWEl6MY X-Forefront-PRVS: 084674B2CF X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(24454002)(377454003)(479174004)(77096005)(47776003)(64126003)(65806001)(65956001)(66066001)(92566002)(50986999)(230783001)(40100003)(87266999)(586003)(65816999)(122386002)(23676002)(59896002)(76176999)(54356999)(6116002)(230700001)(5008740100001)(3846002)(1096002)(33656002)(42186005)(87976001)(36756003)(53416004)(93886004)(50466002)(5004730100002)(19580395003)(110136002)(4326007)(4001350100001)(2950100001)(80316001)(19580405001)(83506001)(189998001)(5001960100002)(2906002);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR07MB2143;H:dl.caveonetworks.com;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjA3TUIyMTQzOzIzOnluZllQcW5KalAzaW4yaVRVNXZjWTRocWVw?= =?utf-8?B?ZHBlVUhtVXBheFNEa0VuSkZ2M3hUVEpldjVFeHJObnJtSlEyU0ZZVW1nTjE5?= =?utf-8?B?WVJELzhqYU5JR3d6NzZwQ3FSZGJHaVA4TzFJR2txTjRPQnFEdjJqUWYvTCtt?= =?utf-8?B?cVF6dkQrQkcrKzQxMkg5VXZFV05kV29lTTV3SFZhWWlsQWtibWtIcWFPWU5l?= =?utf-8?B?NzFuWDZ0UDE2VWNOL1BxSmRWV0Fja1FweDZzSytOVWkva1FRUU10ckQxRmR4?= =?utf-8?B?VDYwMGlBbmtHcVBSeVZzWUp1TXVTNUtaZ1ZVMVRUdDJtNm9aS2k4M2RCSmhN?= =?utf-8?B?WUJsUWJzOHdyV2x3OWtTcExicm5VU25HcVQ0V1NnYmlTdnRpR0ZvY0wxdXZK?= =?utf-8?B?QURlS1BvVFYrMXhDeFl1L1U0NzAwOWtUeXNpRnNnYisySjhrQWtQRlFLSEs2?= =?utf-8?B?ZGUzaDR3S3RKb3RhdmlpTldBcVUzV1pmb0huc3h0VXJwZmdyaDkzS0F2QXdK?= =?utf-8?B?M1V2aEpmR1ltai9BV0xHNjJ3aVlMZUl0STVtdGxmMTBNK1docXhmUTZCV1J2?= =?utf-8?B?VzhaUEc2RHl0a00zaXZkTU1Cam93REtUQXR3WVh0eTh2d3d6cHB0dlhQdzR1?= =?utf-8?B?bGk2TXdyOVdmNlIzQ0V6TWFzMjBaNHlFMERPU08zUnlncE4rYXBPT1FoZG1P?= =?utf-8?B?cUtFRExmS2xqTmgxaGZEbURBZHllZDdnZlg2WGdhcFVhUzJGaXpMK0g5VXlj?= =?utf-8?B?dW1seWpFVjBxR3NIRDhDbTZTSEhYZnZSMTdiV0oxcG5QUnpKdjFSTENqMTlX?= =?utf-8?B?TWVRQy9ScXVHNGxNbEd0eFlkSmlSUTFHbmFTT1FaMjg3ZU1FWWVmbVlEZW5n?= =?utf-8?B?Ym14QzRiYmJPazhaRFp1eXVzcVREb0JoZ0s5L2h0TnlyWVljbFNVVjdMQlVs?= =?utf-8?B?cEtEOW5FdXpTQkV6ODlXOUdERE1DOXVyS2svQnVRdGVDQ04va2ZLL1hqZTRN?= =?utf-8?B?NVhXTG42SnMrSVIvYTJ3cE81eVNlQ1VEZjEvSG1ZKzRnYXNsdmFLRm11Yitv?= =?utf-8?B?eHNwbVNPUzJUUWQvRFRzVDFlOUg2STJOZFp5OUdvcWRlMk0vd3FGa3Z1M29K?= =?utf-8?B?WkNRMzF4Q0NvbjJpSHpwTWRpQ1B4QzErRUJuT1A0LzFPeTFhaEFWWVhSaVp1?= =?utf-8?B?VGlhSlhkbGRsa1ZsMnZqQUgxSGs4RVI3V0N4cTVLRTM3RWZ6bmRjSWZ2bFpu?= =?utf-8?B?S2dWS0kzTXc0cmVnM1JOY2J1aXJKRHFjLzViejFIZ3B6V1RibHRiSWF4VVp2?= =?utf-8?B?OEo2SnhFTnNyT245T2tCSEdUZHNRQUx1REs4c21DTW1BeHFlemhwNTYvTVZ2?= =?utf-8?B?Y1VzSFRNT0xLV01tK1hPaVgyUFNiR0JtVksxcFp1TTJFcFEzOWFkM0Jqc1Iw?= =?utf-8?B?RVVObUcxbmVKZklRRVZPSkUrajdRU1FSYy9UMmpjSUU3Q0g3UElJdC8wZGlD?= =?utf-8?B?UmZWK1pRVjB1QkdKSGxKTjlDUE5FY2NwU1NQb2NBRi9BZGpDTWYzTzlaeU80?= =?utf-8?B?c2kxUXB2RWxuems3WnVHcGUyK0pkd0RzYUY3NTVtd1hYZDhxOE9YNk1EWHZ3?= =?utf-8?Q?HNespEVo29DPUI6VFXti?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR07MB2143;5:mJweASRdI4mBr5vt4/zcVb1as6XztI5uWUepl+f4T8F65IdELOxy9IMmznDDxME1KHLpUQRx2IylJ1v7Sv+sWfajOpMpddm2bmxAV6XJOm7ZxkdWlxOvdHDwhrUG+mwhe3cIAvLFVYWOlpCflEhhhA==;24:J/fMKD/7FsilVeBmXROXABtu9XQpx/cQNQ+aNimgkpajawm13oecCisRCmvzOpHvARxK2twusvbxfTRds5ODbSo1iyCYrs1e1yxWKCdLHO8= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2016 21:39:24.9055 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR07MB2143 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/08/2016 01:12 PM, Rob Herring wrote: > On Mon, Feb 8, 2016 at 2:47 PM, David Daney wrote: >> On 02/08/2016 11:56 AM, Rob Herring wrote: >>> >>> On Fri, Feb 05, 2016 at 03:41:15PM -0800, David Daney wrote: >>>> >>>> From: David Daney > > [...] > >>>> +Properties of the host controller node that differ from >>>> +host-generic-pci.txt: >>>> + >>>> +- compatible : Must be "cavium,pci-host-thunder-ecam" >>>> + >>>> +Example: >>>> + >>>> + pci@84b0,00000000 { >>> >>> >>> Drop the comma, >> >> >> OK... >> >>> and the node name should be "pcie". >>> >> >> Why pcie? >> >> There are no PCIe devices or buses reachable from this type of root complex. >> There are however many PCI devices. > > I thought ECAM is a PCIe thing. If not, then nevermind. Well, Enhanced Configuration Access Mechanism (ECAM) is defined the the PCI Express(R) base Specification, but it just defines a standard layout of address bits to memory map config space operations. Since the PCI config space is a sub set of the PCIe config space, ECAM can also be used in PCI systems. Really, it is a bit of a gray area here as we don't have any bridges to PCIe buses and there are multiple devices residing on each bus, so from that point of view it cannot be PCIe. There are, however, devices that implement the PCI Express Capability structure, so does that make it PCIe? It is not clear what the specifications demand here. I choose to call it "pci" as it lacks much of what it means to be PCIe, and also you cannot plug things into it. David Daney > > Rob >