From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756634AbcBHWWL (ORCPT ); Mon, 8 Feb 2016 17:22:11 -0500 Received: from mx2.suse.de ([195.135.220.15]:54179 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756383AbcBHWWJ (ORCPT ); Mon, 8 Feb 2016 17:22:09 -0500 Subject: Re: [PATCH] clk: meson: Fix meson_clk_register_clks() signature type mismatch To: Stephen Boyd References: <1454879583-27036-1-git-send-email-afaerber@suse.de> <20160208221508.GT4848@codeaurora.org> Cc: linux-arm-kernel@lists.infradead.org, Carlo Caione , Matthias Brugger , Michael Turquette , linux-clk , LKML From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Organization: SUSE Linux GmbH Message-ID: <56B9150E.5010808@suse.de> Date: Mon, 8 Feb 2016 23:22:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <20160208221508.GT4848@codeaurora.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 08.02.2016 um 23:15 schrieb Stephen Boyd: > On 02/07, Andreas Färber wrote: >> As preparation for arm64 based mesongxbb, which pulls in this code once >> enabling ARCH_MESON, fix a size_t vs. unsigned int type mismatch. >> The loop uses a local unsigned int variable, so adopt that type, >> matching the header. >> >> Fixes: 7a29a869434e ("clk: meson: Add support for Meson clock controller") >> Signed-off-by: Andreas Färber >> --- > > Applied to clk-next. It would have been nice to have the > compilation error though Ask and you shall receive: CC drivers/clk/meson/clkc.o drivers/clk/meson/clkc.c:200:13: error: conflicting types for 'meson_clk_register_clks' void __init meson_clk_register_clks(const struct clk_conf *clk_confs, ^ In file included from drivers/clk/meson/clkc.c:22:0: drivers/clk/meson/clkc.h:180:6: note: previous declaration of 'meson_clk_register_clks' was here void meson_clk_register_clks(const struct clk_conf *clk_confs, ^ scripts/Makefile.build:258: recipe for target 'drivers/clk/meson/clkc.o' failed make[3]: *** [drivers/clk/meson/clkc.o] Error 1 scripts/Makefile.build:407: recipe for target 'drivers/clk/meson' failed make[2]: *** [drivers/clk/meson] Error 2 scripts/Makefile.build:407: recipe for target 'drivers/clk' failed make[1]: *** [drivers/clk] Error 2 Makefile:959: recipe for target 'drivers' failed make: *** [drivers] Error 2 Not really telling, is it. ;) Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)