From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933015AbcBILO0 (ORCPT ); Tue, 9 Feb 2016 06:14:26 -0500 Received: from mail-lf0-f43.google.com ([209.85.215.43]:34793 "EHLO mail-lf0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932939AbcBILOJ (ORCPT ); Tue, 9 Feb 2016 06:14:09 -0500 Subject: Re: [PATCH v2 2/2] usb: musb: Fix DMA desired mode for Mentor DMA engine To: Joshua Henderson , linux-kernel@vger.kernel.org References: <1454969730-18480-1-git-send-email-joshua.henderson@microchip.com> <1454969730-18480-2-git-send-email-joshua.henderson@microchip.com> Cc: Cristian Birsan , Felipe Balbi , Greg Kroah-Hartman , linux-usb@vger.kernel.org From: Sergei Shtylyov Message-ID: <56B9C9FE.3070306@cogentembedded.com> Date: Tue, 9 Feb 2016 14:14:06 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1454969730-18480-2-git-send-email-joshua.henderson@microchip.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 2/9/2016 1:15 AM, Joshua Henderson wrote: > From: Cristian Birsan > > Commit 754fe4a92c07 ("usb: musb: Remove ifdefs for TX DMA for musb_host.c") > introduces a problem setting the desired channel mode for the Mentor DMA > engine. > > There is a case where the pointer of the channel DMA mode is incorrectly > assigned to an address, Pointer assigned to address? I don't see how that matches the code. > when it should be assigned the actual mode > value. This results in the value of channel->desired_mode not being > correct. > > Signed-off-by: Cristian Birsan > Signed-off-by: Joshua Henderson > --- > Changes since v1: > - Fix commit comment citing the cause of the regression. > --- > drivers/usb/musb/musb_host.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c > index 6bef86f..b9e24862 100644 > --- a/drivers/usb/musb/musb_host.c > +++ b/drivers/usb/musb/musb_host.c > @@ -662,7 +662,7 @@ static int musb_tx_dma_set_mode_mentor(struct dma_controller *dma, > csr &= ~(MUSB_TXCSR_AUTOSET | MUSB_TXCSR_DMAMODE); > csr |= MUSB_TXCSR_DMAENAB; /* against programmer's guide */ > } > - channel->desired_mode = mode; > + channel->desired_mode = *mode; > musb_writew(epio, MUSB_TXCSR, csr); > > return 0; MBR, Sergei