From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756320AbcBIN1b (ORCPT ); Tue, 9 Feb 2016 08:27:31 -0500 Received: from lists.s-osg.org ([54.187.51.154]:39832 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751841AbcBIN1a (ORCPT ); Tue, 9 Feb 2016 08:27:30 -0500 Subject: Re: [PATCH V6 1/6] regmap: irq: dispose all virtual irq before removing domain To: Laxman Dewangan , lee.jones@linaro.org, alexandre.belloni@free-electrons.com, k.kozlowski@samsung.com, broonie@kernel.org, gregkh@linuxfoundation.org, a.zummo@towertech.it References: <1455020907-4564-1-git-send-email-ldewangan@nvidia.com> <1455020907-4564-2-git-send-email-ldewangan@nvidia.com> From: Javier Martinez Canillas Cc: cw00.choi@samsung.com, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com Message-ID: <56B9E93A.2040903@osg.samsung.com> Date: Tue, 9 Feb 2016 10:27:22 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1455020907-4564-2-git-send-email-ldewangan@nvidia.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Laxman, On 02/09/2016 09:28 AM, Laxman Dewangan wrote: > It is require to dispose all virtual irq of hwirq on chip > created on given irq domain before removing this irq domain. > Hence dispose all mapped irqs before deleting the irq domains > in regmap_del_irq_chip(); > > Signed-off-by: Laxman Dewangan > I believe this patch could be picked separately and not made part of this series since is fixing a bug that happens on most drivers using the regmap-irq API. This will avoid cross-subsystem churn for people. Your patch 6/6 does not introduce a regression since the bug already exists in the MFD driver, it just makes it more noticeable since it is easier to unbind the max77686 RTC driver than the MFD one. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America