From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753463AbcBIOuz (ORCPT ); Tue, 9 Feb 2016 09:50:55 -0500 Received: from lists.s-osg.org ([54.187.51.154]:39990 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750781AbcBIOuy (ORCPT ); Tue, 9 Feb 2016 09:50:54 -0500 Subject: Re: [PATCH V6 1/6] regmap: irq: dispose all virtual irq before removing domain To: Laxman Dewangan , lee.jones@linaro.org, alexandre.belloni@free-electrons.com, k.kozlowski@samsung.com, broonie@kernel.org, gregkh@linuxfoundation.org, a.zummo@towertech.it References: <1455020907-4564-1-git-send-email-ldewangan@nvidia.com> <1455020907-4564-2-git-send-email-ldewangan@nvidia.com> Cc: cw00.choi@samsung.com, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com From: Javier Martinez Canillas Message-ID: <56B9FCC7.1000303@osg.samsung.com> Date: Tue, 9 Feb 2016 11:50:47 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1455020907-4564-2-git-send-email-ldewangan@nvidia.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Laxman, On 02/09/2016 09:28 AM, Laxman Dewangan wrote: > It is require to dispose all virtual irq of hwirq on chip > created on given irq domain before removing this irq domain. > Hence dispose all mapped irqs before deleting the irq domains > in regmap_del_irq_chip(); > > Signed-off-by: Laxman Dewangan > The patch looks good to me and I've also tested on an Exynos5800 Peach Pi Chromebook that S2R works correctly after the RTC dev was unbind so the bug is gone with this version of your series. Reviewed-by: Javier Martinez Canillas Tested-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America