From: Paolo Bonzini <pbonzini@redhat.com>
To: "Radim Krčmář" <rkrcmar@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH 1/3] KVM: APIC: remove unnecessary double checks on APIC existence
Date: Tue, 9 Feb 2016 16:06:17 +0100 [thread overview]
Message-ID: <56BA0069.30606@redhat.com> (raw)
In-Reply-To: <20160209135502.GA30378@potion.brq.redhat.com>
On 09/02/2016 14:55, Radim Krčmář wrote:
> This is most likely going to bug on the following path:
> handle_apic_access -> kvm_lapic_set_eoi
>
> Before the change, handle_apic_access would just drop EOIs that should
> have gone to user space ... I'm not sure if we tested it, or the path is
> really never taken.
cpu_need_virtualize_apic_accesses is needed to set
SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES (vmx_secondary_exec_control) and
SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES is required to get to
handle_apic_access.
Paolo
next prev parent reply other threads:[~2016-02-09 15:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 16:15 [PATCH 0/3] KVM: x86: consolidate "has lapic" checks Paolo Bonzini
2016-02-08 16:15 ` [PATCH 1/3] KVM: APIC: remove unnecessary double checks on APIC existence Paolo Bonzini
2016-02-09 13:55 ` Radim Krčmář
2016-02-09 15:06 ` Paolo Bonzini [this message]
2016-02-09 15:18 ` Radim Krčmář
2016-02-08 16:15 ` [PATCH 2/3] KVM: x86: consolidate "has lapic" checks into irq.c Paolo Bonzini
2016-02-09 14:05 ` Radim Krčmář
2016-02-09 15:07 ` Paolo Bonzini
2016-02-09 15:21 ` Radim Krčmář
2016-02-08 16:15 ` [PATCH 3/3] KVM: x86: consolidate different ways to test for in-kernel LAPIC Paolo Bonzini
2016-02-09 14:14 ` Radim Krčmář
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BA0069.30606@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox