From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757414AbcBIPum (ORCPT ); Tue, 9 Feb 2016 10:50:42 -0500 Received: from mail-bn1bon0059.outbound.protection.outlook.com ([157.56.111.59]:31294 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755760AbcBIPuj (ORCPT ); Tue, 9 Feb 2016 10:50:39 -0500 Authentication-Results: spf=none (sender IP is 165.204.84.222) smtp.mailfrom=amd.com; arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=permerror action=none header.from=amd.com; X-WSS-ID: 0O2AEO9-08-5JL-02 X-M-MSG: Subject: Re: [PATCH V2 09/12] dtb: amd: Add KCS device tree node To: Arnd Bergmann , Suravee Suthikulpanit References: <1454954357-8395-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1454954357-8395-10-git-send-email-Suravee.Suthikulpanit@amd.com> <4018438.bPuTyoUuqf@wuerfel> CC: , , , , , , , , , , , , From: Brijesh Singh Message-ID: <56BA0A2B.5000705@amd.com> Date: Tue, 9 Feb 2016 09:47:55 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <4018438.bPuTyoUuqf@wuerfel> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.222;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(428002)(3190300001)(479174004)(24454002)(199003)(377454003)(189002)(47776003)(65806001)(2950100001)(5004730100002)(106466001)(11100500001)(230700001)(105586002)(5008740100001)(87936001)(33656002)(23746002)(36756003)(5001770100001)(101416001)(19580395003)(77096005)(64126003)(83506001)(189998001)(586003)(1220700001)(6116002)(65816999)(19580405001)(50986999)(92566002)(50466002)(80316001)(76176999)(54356999)(86362001)(2906002)(4001350100001)(4326007)(15975445007)(3846002)(1096002);DIR:OUT;SFP:1101;SCL:1;SRVR:BN4PR12MB0849;H:atltwp02.amd.com;FPR:;SPF:None;MLV:sfv;A:1;MX:1;LANG:en; X-MS-Office365-Filtering-Correlation-Id: e0937603-6b87-4e43-8ca5-08d33168bffc X-Microsoft-Exchange-Diagnostics: 1;BN4PR12MB0849;2:iibt4tSeJzPVA3v979UTtOU1dLFUaLAHJIh8P7FFRQ/dKA+a9iLcRkbNZal41mhGp7oG+hj5opSAHGaUFAmoa/Z+R7UwG0UYmXJ3Yqsy5mGATw1nhHchgKAsmbNzCpxkL5lyTdqmqUPsr3bEo6Cm9irFO7McxD440zIA82fPpiYi5F79RuoCD5sJWPjC8oYw;3:Xx6sUNHayjwmS/udsAkuLuchwZr94gq36ClasswwdLp2WzEp9v2ZaEZD1FlhgRoNybiaGkyCrq2FmfPhA8DTNt447LAInwKoZsRB4Noj75NCX8umVNkFvjbh02705RLRlx9e8Yur6+Dsl9ClOQtZ2Gn1UHe/WE3wA5XAoh1uPRjdsb6rCLX2+UBEdhX6Qe1d4ZxEQu5QtXYC+LIxLDEX9crcaShYmP6tZqq5PQTCVSg=;25:KMdEg1mbnyOC3W7Ebr5dz8Id6fou9/Z53SqrENN7+ozX7A8PrsWAeS6ysknCICDh/1Z3Qkii1QeL7Alz7pjLcnF7KG0TX15SJOmTRX5VwNPhYUHfPqo83gqQYgUUZZ6KmRndnYXBN44IZT39JhHsIesepl1XFrPnCnfj4PmuNgjeE3t0Kj5sdUkW0ZFdAy+G8MWlsebxdwJvygmEpBQxQNzLrR6RjCL6zVRijx+JSCAP4mHA1ND2aVcptLEv2RXWkBjAmvEyZ6iQb1EnTpI+H8AeMFweML/UafxjnGxaJk43HnisfSzzqoCLE5UX6hOT X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN4PR12MB0849; X-Microsoft-Exchange-Diagnostics: 1;BN4PR12MB0849;20:0W9dE1t4jCEJ8X3BFBGT+dXdB9C1sMYQaNxOsahiVHGKUUx8pXQEPicn1uO773Q7GyVj0Jft6QshNsiRhE3wbPnqNENhN+Ve/aZ6kYEOFo73ft+zTFQnfO17dBrH16AMMmG2UcteLcrCq2vF57bghLsEiwhjU9FI/dyqZPC91Zi3qmQGw+YKH5xSo5W217AgBXodi2MKZDufI5+9ray3e693Sv3+60NDoX9GUT3+AnTKTG4jdABseHpcDhmTmpCDLSIsfQG8yhFcZ//q0xriflcQnwNTzBCDkDu/PawaRfl/lbjiIxP1SwtccV2CaUe4y9C60K3kDFzijCb3a1TCBwAzGS39QLBCMOw13kbs+Gb8m8LhEli3ZYTjLtQQscGzscMw5+GjZpCGOHYqt0k5v/VDY0D4QqdwT3D/AYHpDyfBzBKEpY3Dv+vzFXLBvboBFr+w4gb0Q3kB81Aj5HVb/50J+G14b4dH6Yj6su/RDy7KGYE2yLbPSWCZ+S2p1wRY X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13018025)(13015025)(13023025)(8121501046)(13017025)(13024025)(5005006)(10201501046)(3002001);SRVR:BN4PR12MB0849;BCL:0;PCL:0;RULEID:;SRVR:BN4PR12MB0849; X-Microsoft-Exchange-Diagnostics: 1;BN4PR12MB0849;4:TnRj6WzXEJLYrKlDOcuM5dv2U4nSgNObzLcEvGDxEajnqdweRT8uEk/eYoGftliiSDXOP1/z26hl86q6j6OwfG3xQJyi+lC9XG/yz0hcGTj6gKOl+Tgc6v9EiHBQ31XgfVmrOhsJgT+vfuW9OSnNXyQjZZORkfzAT4wsu6d2DZU/lUYV0Wig3Ik50TwdU3uG2iTBoQFLRwe/b7qooGAd8NgAWsCVPclCaJ+b47pbzskMN3rYnufyzRxyJcpzWxXwn0pzujTbzJOPiDPPLfzvCN2k+PIfQEArdKhSPUdAj8hH5m4FrF6h73kihCENp/lq2pHObielYjpjSHkzFIyalJi3fGtCPVBfnHnrM01zoqFpPcXFNdQLBhyzsA/v+1U05TfnwcHIh2cqj7q+Z2NNWdjSZS13dOD1wCofcZ2FnPPIU8iDC2Tp3lwId6YWeJftnjPcJFoUr55HZNRchUTFWg== X-Forefront-PRVS: 08476BC6EF X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN4PR12MB0849;23:FAzdWDBck6r+VEMCiIATZIU667C2/3bHsokOy?= =?Windows-1252?Q?tjuE2rsqaS1AIHqB2LZvARfpklM1KyTUwb6WskrQ0zCYC4ZkW7htKVaL?= =?Windows-1252?Q?SNkKVapF5kEwWx/x9Q3z4Xl7mIS5+1ZLehNoaa2fUjq2ZrUyCaV9BK5p?= =?Windows-1252?Q?AMWSspLdDqeCEqvAmoCUmUlaS/YqYLGMc5tk7u9Ralrg9T/MF5yGqaKK?= =?Windows-1252?Q?E9Mo3bttfwcfPeVbBwbGeqFYutYIVYvZGwDATb89vtyhapkYxCiUkKZQ?= =?Windows-1252?Q?POOq7FFg6ofsUj6ub/dAYdoXpRk3IiaqSAKvIq7vGdBvJr8aiAcScK/4?= =?Windows-1252?Q?DTCqkDNgxsB/MBfgOs+conHJwIAjcwvayNvvmkUApusZ3RPLXnaHTITD?= =?Windows-1252?Q?1Wl0ZdVdSn3UjraYfdu3eKeOgPgKP9jXJS7jv8HR3YNqHrdX0m87nG8+?= =?Windows-1252?Q?2V73BmldRXkByMcAOnaLluBvYVCZuAZn3TrhuvJO5VSFpF+jlJ07VYY4?= =?Windows-1252?Q?shghU5yA7ULJp0imntcUpD67qtgb5G/uE+we5ahKnaXbFfwCWn2Zo/lp?= =?Windows-1252?Q?33belPWQlbqvMPzki+W+X23EEAc2tl68jO/19YaC+R4Lm0WwxPhXal8H?= =?Windows-1252?Q?K17ssF/OaVdcJQKvOonlYsMsN2QVcn98o2ktyGhcwvyn37eKvfkaLTIS?= =?Windows-1252?Q?PVfmdf6kqp1CAsBdTMec8BWe3fyrgHO4pG2IdzFZ7H11fG14JjY5UZKs?= =?Windows-1252?Q?POpQjZ0DZOc4PN4nCjSajtGPyFsvyp4nKcTxikMb8HgO6i7Gta/i6Vpw?= =?Windows-1252?Q?e1eJilrmmQDCgE5cOhkz+GYhOlLv5fnFTV1kYIs7/ukiuWLhZ4zgcVCn?= =?Windows-1252?Q?qgJemGJeQiz2dhlOzmurNhGLVBsiA1T/0y9wtikQwabDh/PBGBilSK8K?= =?Windows-1252?Q?4PcJa/caGgXf63/hLY5254b7ahNpxIL3uLVvd3w+BZhAB/FBPHVonMyl?= =?Windows-1252?Q?KMgdH5BddtvbIGdX5jezjW/NlK8Hjr8TUwVuQYBq9Y7+UDdL+94IUg/2?= =?Windows-1252?Q?HwFHwWr+JG9SsSKa/qq79v5yBic16VCTAULFZxl5F+xq/e0HmaE9V5A0?= =?Windows-1252?Q?omaVx0a8QkCMlSqOVHNPVrCG1U6GtZmQos5ZKpuAzpAEE1i9dhWtT3AR?= =?Windows-1252?Q?3koD5U4gMjClKluT7rxPLlCDcQYlxIo+/Gv3JNA3cLyrtg3IgdvY0FhT?= =?Windows-1252?Q?U2F+gbj/+asafBg43Qw6Ecc420XkhKsJv+BCeI7g4SN2SHeEt0uluyeV?= =?Windows-1252?Q?/HecSaQDraYewQKX2JUyfdvsA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN4PR12MB0849;5:bEf8muXzVuQd9x8hec37J5o155uGnm183hJLXEDY0lFUmo4qxkat7BmIOUe8oibcUmMWiaU7c8jGVTPuqj3+Fe2Hm+d1+UVHPW52DI3MwyPoPLBaSqgXIDMH4hqzJrugNb4/gfzjHzH+cmgvExtFew==;24:qA9sWS9B7Labr5weouQZfmIhJ1n4qXg/7JC1qjbbKfQwmFoJvMe1lLVcrIRXbioPEeqeZsvISqkzUcEMHMt2jkVHW6sfAWWHevaRy9a2sWc=;20:w5VGyY84f/h6DyMJfpiANSbwBKu+5NadVFd98bbHrIfVXiYSZsY0D6nhr2f78g7+DDUNhlRMD6Oaterap9ecs2YQIKemgArOkRo5O/LiAFOpe0WmPe0vRgMwPk7LdBYbUtD/APjLqFgaBlTwEvoM/n4zD61MU3iESiKn3cpTQ+sLcLwTwVd2CuBCpAAEgks8tlHQRrveDG0QfX1QQqsJaWICpnLO5DZ9EazMRrTzQzqGFfjhLJOtKR1xSjS0cSia SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2016 15:50:34.4543 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.222];Helo=[atltwp02.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN4PR12MB0849 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 02/09/2016 08:59 AM, Arnd Bergmann wrote: > On Monday 08 February 2016 11:59:14 Suravee Suthikulpanit wrote: >> + >> + ipmi_kcs: kcs@e0010000 { >> + status = "disabled"; >> + compatible = "ipmi-kcs"; >> + device_type = "ipmi"; >> + reg = <0x0 0xe0010000 0 0x8>; >> + interrupts = <0 389 4>; >> + interrupt-names = "ipmi_kcs"; >> + reg-size = <1>; >> + reg-spacing = <4>; >> + }; >> }; >> > > I see we don't have a binding file for this, can you add one please? > There is binding file ipmi.txt [1]. Am I missing something ? [1] http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/ipmi.txt > > Why the strange name for the interrupt? > Now I don't remember the doc but sometime back while implementing BMC on Seattle I saw that interrupt was labeled as "ipmi_kcs" hence used the same name in DT. But if you want to use different name then let me know the string and will update it. Theoretically IPMI system interface supports the following interface and any of these interfaces can be used by A57 to communicate with BMC: * Keyboard controller style (KCS) * System Management Interface (SMIC) * Block transfer (BT) * SMBus system interface (SSIF) AMD Seattle platform supports "KCS". > Arnd >