From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932923AbcBIQO1 (ORCPT ); Tue, 9 Feb 2016 11:14:27 -0500 Received: from mail-bl2on0078.outbound.protection.outlook.com ([65.55.169.78]:47205 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932650AbcBIQOV (ORCPT ); Tue, 9 Feb 2016 11:14:21 -0500 Authentication-Results: spf=none (sender IP is 165.204.84.222) smtp.mailfrom=amd.com; arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=permerror action=none header.from=amd.com; X-WSS-ID: 0O2AFRS-08-614-02 X-M-MSG: Subject: Re: [PATCH V2 09/12] dtb: amd: Add KCS device tree node To: Arnd Bergmann , References: <1454954357-8395-1-git-send-email-Suravee.Suthikulpanit@amd.com> <4018438.bPuTyoUuqf@wuerfel> <56BA0A2B.5000705@amd.com> <15181064.RzzsN4CWec@wuerfel> CC: , Suravee Suthikulpanit , , , , , , , , , , , From: Brijesh Singh Message-ID: <56BA0FBA.1010202@amd.com> Date: Tue, 9 Feb 2016 10:11:38 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <15181064.RzzsN4CWec@wuerfel> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.222;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(428002)(3190300001)(377454003)(199003)(24454002)(189002)(479174004)(83506001)(64126003)(5001770100001)(101416001)(4001350100001)(36756003)(77096005)(50466002)(586003)(54356999)(80316001)(189998001)(76176999)(65816999)(92566002)(50986999)(1220700001)(1096002)(86362001)(6116002)(2906002)(3846002)(4326007)(230700001)(105586002)(5004730100002)(2950100001)(47776003)(65806001)(11100500001)(93886004)(23746002)(87936001)(33656002)(5008740100001)(106466001);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR12MB0710;H:atltwp02.amd.com;FPR:;SPF:None;MLV:sfv;A:1;MX:1;LANG:en; X-MS-Office365-Filtering-Correlation-Id: 28314acd-2f76-46ec-186a-08d3316c0fcd X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0710;2:962r/l1iGWoVZpOwMyJpBxORa0JyJ/v4a9ObDA2BEIjgfsVbLIvmv9mWpkZ2j/Y5+KHmLw75mjbo0S2pOv5CsBTpTR0TWMiyP08S6WEuTKacMneQpF6SsmyzFd84QWAM/RYPxOxfASWF0ciqDRRlgC7Pl9Gu7TZNiXlEbIahuFn14bHLnjzWG+lbkjeqBMIV;3:fAml77plPq5CAtMLif/ssqGXYEQyFnX17SIrSUe4oKaJYKg5ALjhwxsgJSQmatLTt+ofj63oECFghfUPvEmqrdE2GRVQDGMzyuhFf5xnL0Iu4vMZ79PmZbCiX5iCe4jo2CRfl3dKi37WkELTEZNdi7QjVRusGTK90yfkfkxlXk5kaUBpyySos1KaerjzFlAEX2jVpJiBSMJXP8Tse47g50yP2BsdBQv9u+dHvdL8fBE=;25:WWXM9LduJvJQLRh4gHf/AsL6zM6i2siTpOimxjwxlKkq1doQAsj4M1qyYIQcVVQLzMh5EUTB+sO7wFFZhDBWJo7Xu0JfkrLfC35HsJdDRM1T0eQcUeOcsuwJmBKCJ8/OQDk6TBqQZimGTCTTddL7CtOo/be/ha1I3zP0kEUBcnSD82UvZ056iSNGgLu3xH0JLg3L0xW7bUdSgqQxXkDNlv1ES1JwJ1stNp0v5k+22P20KEl1LOtXup2+WuHqjTNo1tl7tDwix/GaeKjllzq88f8Ngr3fVUBUnmQ6gVfKud3mxCZ4TWIbihcDt6XWCJL0 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR12MB0710; X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0710;20:ISh9NatMMIbfyBayAt9NJTFbduInPpLVodODodeAZXZSGaq2+4UkzEMFFL/bgJmzZxlyK0yiazGSdipv9dVZJf/kpwfsaIxmrti24ztORaFXKSx8lRW6HnqoI56997Q3wmWeF1e5HpuJEqC9gFWn7iigxuB3i+Wi247TJBQUM0V7WLnDRIdqh5qQmeNxWts7Sq7tMhVK3gs/qBPBkh2hu8gmkE5IPpWANTlF44cZ5QVar/at8eCjXpMwFxrzADztQoiN/2zo+6DPxns0DGirVBUUsoDlmFsIWg4oQersk2myVFOD8fKkRDAEypV36gLPBj1LFcX5B0t/0nbzAe7N6A4W5cR5EufkvhXc/re3XBmL46Ow+CiM65h355eYMizdKXSgHPNrsYXkH6kEr3kugFjYhKWbW3McxJKvY29+QwcAjUe74o3Xws1caGEd2dPzFJeqacg6GvnQzIMBd6MP2tumq4M7wr+qviz1kCWpNMfsMWvCrnkdJydCc9xYUDqC X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13015025)(13017025)(5005006)(8121501046)(13024025)(13018025)(13023025)(10201501046)(3002001);SRVR:BY2PR12MB0710;BCL:0;PCL:0;RULEID:;SRVR:BY2PR12MB0710; X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0710;4:mFEtUbtGxEnWe/3+5XVYw7mFimKJSKTAQtrnuW+79RJnSCPrnlNpRdkbLjCz3M4Z120exvVPY9NWEOMWQxNpzoiJmmhTEaYPMGs/p75vGug8NGsWGnjzgvWowJn1wnjaRJ5GfaSQQSat4ENagCkCecs/u46yJaHa2sW/WwUfS52e0oZWyfdN+K3BFBhI1WnvcOsIgcEOUwzOTfL46G5mzveZMX5ZMczu2U69WFjRoBebRct4e/iv9syGNTMfiBUCguwJGmhrB7Mmt85r1DxeeGTuXr06Fl+JybX2FALmtbHFlQLaJCdxFKOebQejVMuAxko/vKPgkAaliiCJUwFarRzkw5IngdmkQ8ww+SK65HJTmlv3ohzgPyCORjSYzWQPn3Zl+8VEghTCtddOmPiTLr+eqhDHn/4iIxZ0MYs73Wh1WnZnUo0+PwhOFXAPrda/Jkkv4AK0vT4dmnKkE3FOsQ== X-Forefront-PRVS: 08476BC6EF X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BY2PR12MB0710;23:Z54opHv6uHcCsMq4pvHX4F8/aQ/xM1Y4WdcG+?= =?Windows-1252?Q?0V3llHsxCxUCy/obnISV3OelISID3FPp7Vb3QxlisABO6P9XkCzdBYo3?= =?Windows-1252?Q?zNw2rAcfg5rBJQoPPmr9IW8J66AtIQ+28I9qK0CbkDYd3z76QnFlGcQr?= =?Windows-1252?Q?J7J+cEtEoA6Nn+71vz7iK/jlXmB2RCAmrOatiYGMzG27ThhTLUfBznQp?= =?Windows-1252?Q?vdu3w8CexYhPzNFBg1WDhk4stwiA/II7YJ89EQtBPc9kai4kXG8Cdrmo?= =?Windows-1252?Q?xDjRKTE4s0FUdCVNhZZKhLvfs+2xVTggqZxfdRVd5nlce6KaOfVBWMP+?= =?Windows-1252?Q?HLv7Dghn+5L6haROAZ9hZUZPDbTBI2osP9Clv22EE+knuXXcXmLTX5Dx?= =?Windows-1252?Q?CnburLzm+Ir705oR7PvHz1pGNHzoOVZjEVEh1wTZXzvJxOOMCbk9AVPM?= =?Windows-1252?Q?zJRw4Y43u/QvJRW5o+j4yz78HBiEZipEWI6iPTkjT0UJfHp8GWWPxU8N?= =?Windows-1252?Q?PIWm9Np2mGjXlUnEbOLMfOJhcES+MLN+SGyNoBHF5R4wkIR3A8XOH8gF?= =?Windows-1252?Q?HEMjOSbquhGSJ70Sjh5wvAMe0hn5EBkw2BwMgtVRKbAUQpg6V7f0SpDP?= =?Windows-1252?Q?l94iGFy2itBY+qgx4NY2wqhMlJ4ke3BvsztFOuyCVY8KKPJg1HBR3Qm4?= =?Windows-1252?Q?jrsSMWj8v3DBDeqQrNSDEZR/2EgOdGh6QeHE1JBUevVzJ3A58Xnn+R87?= =?Windows-1252?Q?8wxs4AaxwOAcdz2BpF3AQH2QNXUAi0OAiHkebWlRMTqL+9jJjbmnGkDG?= =?Windows-1252?Q?ctR/hyp8bbvDyPjCt5iuEi3l+Vqvt2+YBPDngJzikEbzU5iSMCLTSjUQ?= =?Windows-1252?Q?/SpGN71tw8+pTZ5yjZPKEiq+zssiqgMynz81EqqBao/Tb1/UA+boDyf8?= =?Windows-1252?Q?sE9vdGXyLwgwd2hDkSV4LgW8vCD3nATOy9C3Mb811EtvP0b8o2p3k5t8?= =?Windows-1252?Q?z0N/FnuavSyGz0ydXAR2t5oiV1hBHqbeizeR65dR/h3vkS09QIt4KkYA?= =?Windows-1252?Q?yum0lTQpsVoooAp5aP/H65gIb00xDftfVku2aEe4268o22o1SkdE8TLQ?= =?Windows-1252?Q?DPPsMXfgIx0LPb/IYsgtOZsM9fRDz4vkos7l5zrdjCjGDp35oeNq0JRd?= =?Windows-1252?Q?asWQn8RUIb9PikrEUWtouu7NDWIAuaqkMmkTbDFuKFpCQbISQn1q81iD?= =?Windows-1252?Q?Q+AEEwtl+QxGGozNQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0710;5:aXFfgew+nC0+MmYB5ZJ9Hre3ZI+HaC2gNBGcxMbvEhNHXIbOAxEvCZETXuz1wpN1oh+cgeqy9Pih6OZ1pES068EDZiKKPKgH/C23AZ9HMBZLIbY1yLUYmI/CoRO1SX+D5kWTXIo9KHygkIMYY1AH6g==;24:H4J+1MoJx7AC7lTSxG3cvyWaa+OPCs5r2DoTJK7LJtT+4hnELYF6Aa+SFaSf03WtXV23Pas/8YhBYCVLvUN77q2hsmzWg9BxBs1YjUiddgw=;20:lxZJwUGWHSvjboNio8/lrDx6qrARv3fH/P2YRur4ByAyc1YJ7wYFS9a957fWMBPaVCuTQOtxMc8M0Z60CXPNrCPFfT8zlNW7Tc9ZucjuWo8QOOcOHjI0Q6mEmJdgkYpjru/0q9cdB6HRm7CSp4kGMNnEnd+dbwAx2/dLzpgsCbI5bolaJM441/T/7yK3R4e6LoJUtL9fcAbQfNQaFpanSwQP66sGHys5w8gXYIvysilKIZ3nmoEH+0sMmbSQ48Yr SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2016 16:14:17.2575 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.222];Helo=[atltwp02.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR12MB0710 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 02/09/2016 10:00 AM, Arnd Bergmann wrote: > > The important part for interrupt/reg/... names is that you must use exactly the > names that are listed in the binding. If there is no name in there, it's better > not to add the name property. > > The other point is that "ipmi_kcs" is a name that is picked really badly, as it > uses a '_' character while DT properties by convention use '-' between names, > and the name of the IRQ is the same as the device itself, which is really > not a useful way to disambiguate multiple interrupts in the same device, if > someone ever adds another irq line. > Sure we will drop the name field. Thanks. > Arnd >