From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756738AbcBIROJ (ORCPT ); Tue, 9 Feb 2016 12:14:09 -0500 Received: from mail-ob0-f173.google.com ([209.85.214.173]:33640 "EHLO mail-ob0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753398AbcBIROG (ORCPT ); Tue, 9 Feb 2016 12:14:06 -0500 Subject: Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional To: Christoph Hellwig References: <1454783624.2809.6.camel@HansenPartnership.com> <20160207092241.GA15331@lst.de> <1454861040.2329.4.camel@HansenPartnership.com> <56B7C527.6050300@kernel.dk> <20160209125011.GC25353@lst.de> <20160209171229.GA30378@lst.de> Cc: James Bottomley , "linux-nvme@lists.infradead.org" , linux-block@vger.kernel.org, linux-scsi , linux-kernel From: Jens Axboe Message-ID: <56BA1E5C.7040108@kernel.dk> Date: Tue, 9 Feb 2016 10:14:04 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160209171229.GA30378@lst.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/09/2016 10:12 AM, Christoph Hellwig wrote: > Does this looks reasonable? > > --- > From 7843fae979df3fc14007735f54cc6bb2f6f66dc5 Mon Sep 17 00:00:00 2001 > From: Christoph Hellwig > Date: Tue, 9 Feb 2016 18:11:32 +0100 > Subject: nvme: fix Kconfig description for BLK_DEV_NVME_SCSI > > Signed-off-by: Christoph Hellwig > --- > drivers/nvme/host/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/nvme/host/Kconfig b/drivers/nvme/host/Kconfig > index 59307f8..2e24156 100644 > --- a/drivers/nvme/host/Kconfig > +++ b/drivers/nvme/host/Kconfig > @@ -17,8 +17,8 @@ config BLK_DEV_NVME_SCSI > and block devices nodes, as well a a translation for a small > number of selected SCSI commands to NVMe commands to the NVMe > driver. If you don't know what this means you probably want > - to say N here, and if you know what it means you probably > - want to say N as well. > + to say N here, unless you run a distro that abuses this for > + stable device names like some OpenSuSE and SLES versions. Yep, that looks a lot more reasonable to me. Might be wort including that it impacts the mount-by-id on those distros. -- Jens Axboe