From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757646AbcBJLyR (ORCPT ); Wed, 10 Feb 2016 06:54:17 -0500 Received: from mga01.intel.com ([192.55.52.88]:21615 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757562AbcBJLyP (ORCPT ); Wed, 10 Feb 2016 06:54:15 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,425,1449561600"; d="scan'208";a="909205458" Subject: Re: [RFC PATCH] mmc: sdhci-of-at91: don't put device in suspend after probe To: Ludovic Desroches References: <1455098283-14500-1-git-send-email-ludovic.desroches@atmel.com> Cc: ulf.hansson@linaro.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, nicolas.ferre@atmel.com From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <56BB2414.1040606@intel.com> Date: Wed, 10 Feb 2016 13:50:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1455098283-14500-1-git-send-email-ludovic.desroches@atmel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/02/16 11:58, Ludovic Desroches wrote: > By putting the device in suspend at the end of the probe, it is > impossible to wake up on non software event such as card > insertion/removal. > > Signed-off-by: Ludovic Desroches > --- > > Hi, > > Since I had no feedback on this topic: > http://permalink.gmane.org/gmane.linux.kernel.mmc/35160 > > I would like to no more put the device in suspend at the end of the probe. If > my device is suspended at the end of the probe, I have no issue to resume on > a software event such as mounting my sdcard but hardware event such as card > insertion and removal do not trigger a resume. You can't use runtime PM unless you have a way to wake-up. Currently, sdhci disables card detect interrupts when runtime suspended, and drivers use a card-detect GPIO to wake-up. > > It seems there are only two sdhci drivers using runtime pm so maybe nobody has > noticed this issue. > > Regards > > Ludovic > > drivers/mmc/host/sdhci-of-at91.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c > index 9cb86fb..ae24dea 100644 > --- a/drivers/mmc/host/sdhci-of-at91.c > +++ b/drivers/mmc/host/sdhci-of-at91.c > @@ -210,8 +210,6 @@ static int sdhci_at91_probe(struct platform_device *pdev) > if (ret) > goto pm_runtime_disable; > > - pm_runtime_put_autosuspend(&pdev->dev); > - > return 0; > > pm_runtime_disable: >