From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752298AbcBJXN1 (ORCPT ); Wed, 10 Feb 2016 18:13:27 -0500 Received: from mga14.intel.com ([192.55.52.115]:38410 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751107AbcBJXN0 (ORCPT ); Wed, 10 Feb 2016 18:13:26 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,427,1449561600"; d="scan'208";a="45881095" Subject: Re: [PATCH v5 1/3] crypto: KEYS: convert public key and digsig asym to the akcipher api To: David Howells References: <20160202180853.2887.82271.stgit@tstruk-mobl1> <20160202180848.2887.9937.stgit@tstruk-mobl1> <5286.1455113876@warthog.procyon.org.uk> Cc: herbert@gondor.apana.org.au, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-crypto@vger.kernel.org, zohar@linux.vnet.ibm.com From: Tadeusz Struk Message-ID: <56BBC321.1000503@intel.com> Date: Wed, 10 Feb 2016 15:09:21 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <5286.1455113876@warthog.procyon.org.uk> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi David, On 02/10/2016 06:17 AM, David Howells wrote: > Why didn't you put the RSA signature parsing - ie. where the OID and the other > bits are checked - into crypto/rsa.c? > Do you want to get rid of the crypto/asymmetric_keys/rsa.c completely? I wanted to make the conversion churn as small as possible. I can move it in a subsequent patch if you want. Thanks, -- TS